This repository has been archived by the owner on Dec 6, 2023. It is now read-only.
script for setup of redis binary service #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
biswaroop1547
commented
Nov 3, 2023
•
biswaroop1547
commented
- part of Add Redis service as binary bit-gpt/registry#96
biswaroop1547
temporarily deployed
to
internal
GitHub Actions
Inactive
biswaroop1547
force-pushed
the
redis-binary
branch
from
44fb5a4
to
484b210
Compare
biswaroop1547
temporarily deployed
to
internal
GitHub Actions
Inactive
casperdcl
suggested changes
Nov 3, 2023
biswaroop1547
temporarily deployed
to
internal
GitHub Actions
Inactive
Co-authored-by: Casper da Costa-Luis <casper.dcl@physics.org>
biswaroop1547
temporarily deployed
to
internal
GitHub Actions
Inactive
biswaroop1547
temporarily deployed
to
internal
GitHub Actions
Inactive
casperdcl
reviewed
Nov 3, 2023
casperdcl
reviewed
Nov 3, 2023
biswaroop1547
temporarily deployed
to
internal
GitHub Actions
Inactive
Co-authored-by: Casper da Costa-Luis <casper.dcl@physics.org>
biswaroop1547
temporarily deployed
to
internal
GitHub Actions
Inactive
casperdcl
previously approved these changes
Nov 3, 2023
casperdcl
reviewed
Nov 3, 2023
There was a problem hiding this comment.
btw probably wanna forward args, right? could use to configure ports etc. https://stackoverflow.com/q/55078246
biswaroop1547
temporarily deployed
to
internal
GitHub Actions
Inactive
|
btw the failing (nonexistent) docker build can either be ignored, or replaced with a simple |
biswaroop1547
temporarily deployed
to
internal
GitHub Actions
Inactive
casperdcl
approved these changes
Nov 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.