Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

206 sourcing a file will lose the current path value #248

Merged

Conversation

prsabahrami
Copy link
Contributor

Fixes #206.
I also updated the behaviour of exit command in subshells.
Before this PR:

(exit)

would exit the shell.
However, this is not expected behaviour and is fixed in this PR.

@prsabahrami prsabahrami linked an issue Feb 14, 2025 that may be closed by this pull request
@prsabahrami prsabahrami requested review from wolfv and certik and removed request for wolfv February 14, 2025 17:08
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 30.00000% with 42 lines in your changes missing coverage. Please review.

Project coverage is 63.89%. Comparing base (1405935) to head (6505739).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/deno_task_shell/src/shell/execute.rs 42.85% 20 Missing ⚠️
crates/deno_task_shell/src/shell/types.rs 12.50% 7 Missing ⚠️
crates/shell/src/execute.rs 0.00% 7 Missing ⚠️
crates/shell/src/main.rs 0.00% 7 Missing ⚠️
crates/shell/src/commands/set.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
- Coverage   64.06%   63.89%   -0.18%     
==========================================
  Files          32       32              
  Lines        3648     3664      +16     
==========================================
+ Hits         2337     2341       +4     
- Misses       1311     1323      +12     
Files with missing lines Coverage Δ
crates/deno_task_shell/src/shell/commands/exit.rs 100.00% <100.00%> (ø)
crates/shell/src/commands/set.rs 83.33% <0.00%> (ø)
crates/deno_task_shell/src/shell/types.rs 51.09% <12.50%> (-0.38%) ⬇️
crates/shell/src/execute.rs 0.00% <0.00%> (ø)
crates/shell/src/main.rs 0.00% <0.00%> (ø)
crates/deno_task_shell/src/shell/execute.rs 75.78% <42.85%> (-0.44%) ⬇️

... and 1 file with indirect coverage changes

@prsabahrami prsabahrami merged commit 175858c into main Feb 17, 2025
7 checks passed
@prsabahrami prsabahrami deleted the 206-sourcing-a-file-will-lose-the-current-path-value branch February 17, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sourcing a file will lose the current PATH value
2 participants