Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolver issue where unreachable code is reached #13

Closed
wolfv opened this issue Jan 17, 2024 · 0 comments · Fixed by #15
Closed

resolver issue where unreachable code is reached #13

wolfv opened this issue Jan 17, 2024 · 0 comments · Fixed by #15

Comments

@wolfv
Copy link
Member

wolfv commented Jan 17, 2024

We hit the following – supposedly unreachable code – in certain cases:

thread 'main' panicked at 'internal error: entered unreachable code: when we get here it means that all candidates have been assigned false. This should not be able to happen at this point because during propagation the solvable should have been assigned false as well.', /Users/tdejager/.cargo/registry/src/index.crates.io-6f17d22bba15001f/resolvo-0.2.0/src/solver/mod.rs:584:53
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

A test has been added to resolvo that recreates the issue #10.
@aochagavia aochagavia mentioned this issue Jan 24, 2024
Merged
baszalmstra pushed a commit that referenced this issue Jan 25, 2024
@aochagavia
fix: incremental solving (rip issue #75) (#15)
6ff4fcf 
The original bug was caused by adding a conflicting `requires` clause,
yet failing to detect and handle the conflict. This commit introduces a
clearer separation between: adding new clauses, detecting conflicts, and
handling said conflicts.

Closes #13 

Closes prefix-dev/rip#75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: incremental solving (rip issue #75) aochagavia/resolvo
1 participant
@wolfv