-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: only build non-reproducible builds #151
Conversation
src/repror/cli/cli.py
Outdated
@@ -55,9 +56,9 @@ def main( | |||
|
|||
|
|||
@app.command() | |||
def generate_recipes(): | |||
def generate_recipes(all: Annotated[bool, typer.Option()] = False): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all is a reservered word, maybe we can use all_
src/repror/cli/generate_recipes.py
Outdated
def generate_recipes(): | ||
"""Generate list of recipes from the configuration file.""" | ||
def _generate_recipes( | ||
rattler_build_hash: str, all: bool = False, config_path: Optional[Path] = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here with all
src/repror/cli/generate_recipes.py
Outdated
def generate_recipes(): | ||
"""Generate list of recipes from the configuration file.""" | ||
def _generate_recipes( | ||
rattler_build_hash: str, all: bool = False, config_path: Optional[Path] = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can use config_path = Path('config.yaml') as default argument
Two things in this PR: