support setting host_platform
explicitly
#1087
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@isuruf I started a PR here to add
--host-platform
to the arguments.The current logic is:
The
host_platform
is defaulted toPlatform::current()
.If
target_platform
is unset, then we initialize it to the value ofhost_platform
.If
target_platform
is set to something (noarch is forbidden to set btw), thenhost_platform
is set to this value too, if it is not set explicitly (so the current logic continues to work).Would be great if you let me know if that makes sense to you and what use-cases you had in mind.