fix: use compilers instead of custom set of dependencies #3337
+1,409
−2,278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfv
approved these changes
Mar 12, 2025
|
great! |
wolfv
reviewed
Mar 12, 2025
| cxx-compiler = "1.5.2.*" | ||
| make = ">=4.3,<5" | ||
| ninja = "1.11.1.*" | ||
| compilers = ">=1.9.0, <2" |
There was a problem hiding this comment.
I am wondering - cmake is not there but should be, probably?
And the downside of compilers is that it also pulls in fortran-compiler. Maybe using c-compiler and cxx-compiler would suffice?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken on macos, this change makes it work again.