Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 show Aggregation bin-size in legend text + dynamic callback support #35

Merged
merged 17 commits into from
Mar 11, 2022

Conversation

jonasvdd
Copy link
Member

@jonasvdd jonasvdd commented Mar 10, 2022

New features:

  • Updated traceupdater to v0.0.8 where partial graph-ID matching is performed (is needed for the basic example)
  • Decoupled the register_update_graph function so that it is more convenient to create dynamic callbacks.

TODO:

  • Dash examples of dynamic callbacks
  • Update the example README
  • Add a heuristic for the resampling functionality
  • Still need to decide whether we show the aggregation bin-size by default or not
  • Create a new release

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022

Codecov Report

Attention: Patch coverage is 99.18033% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.97%. Comparing base (0583ab6) to head (835ea0d).
Report is 534 commits behind head on main.

Files with missing lines Patch % Lines
plotly_resampler/figure_resampler.py 98.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   98.21%   98.97%   +0.75%     
==========================================
  Files           5        6       +1     
  Lines         336      389      +53     
==========================================
+ Hits          330      385      +55     
+ Misses          6        4       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonasvdd jonasvdd requested a review from jvdd March 11, 2022 16:19
@jonasvdd jonasvdd added the enhancement New feature or request label Mar 11, 2022
Copy link
Member

@jvdd jvdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive work! 🔥

@jvdd jvdd merged commit 1c309d6 into main Mar 11, 2022
@jvdd jvdd deleted the aggregation_feature branch May 1, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants