-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rangeslider support #254
Rangeslider support #254
Conversation
This reverts commit 87bd318.
Add example result gifs! 😁 |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #254 +/- ##
==========================================
- Coverage 96.87% 96.53% -0.34%
==========================================
Files 14 14
Lines 1024 1127 +103
==========================================
+ Hits 992 1088 +96
- Misses 32 39 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Ready for review @jvdd! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Amazing work mate 🦘 🤝
This is a first draft of cleaned version of rangeslider support:
Still to do:
How it looks now
![Peek 2023-10-25 01-51](https://private-user-images.githubusercontent.com/38005924/277856039-d3ad8ff4-8ed5-49b2-8b65-17d70a3690c3.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NjgyODYsIm5iZiI6MTczOTQ2Nzk4NiwicGF0aCI6Ii8zODAwNTkyNC8yNzc4NTYwMzktZDNhZDhmZjQtOGVkNS00OWIyLThiNjUtMTdkNzBhMzY5MGMzLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDE3MzMwNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNlOWNmMGY1NmUzNDVhZWVmZTk1ZTg2YmRlY2ExZTI0MDNmMzYzZmUyZDYwZjM2YTExOWJjNjAxOWZiZDU5ZTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.QjrWzzgBdYnS0Fxp1lqqSe0HhMzsPOhqNNt7XZUkqa8)