Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 fix typo in docstring + remove LTTB from MinMaxLTTB + remove interleave_gaps #201

Merged
merged 10 commits into from
Apr 30, 2023

Conversation

jonasvdd
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2023

Codecov Report

Merging #201 (a43fa54) into main (614c9de) will decrease coverage by 0.33%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
- Coverage   97.44%   97.11%   -0.33%     
==========================================
  Files          13       13              
  Lines         979      972       -7     
==========================================
- Hits          954      944      -10     
- Misses         25       28       +3     
Impacted Files Coverage Δ
...tly_resampler/aggregation/aggregation_interface.py 94.91% <ø> (-0.09%) ⬇️
...tly_resampler/figure_resampler/figure_resampler.py 89.16% <ø> (ø)
...ler/figure_resampler/figure_resampler_interface.py 100.00% <ø> (ø)
plotly_resampler/aggregation/aggregators.py 100.00% <100.00%> (ø)
plotly_resampler/aggregation/gap_handlers.py 96.00% <100.00%> (-4.00%) ⬇️
..._resampler/aggregation/plotly_aggregator_parser.py 94.44% <100.00%> (-2.19%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jvdd
Copy link
Member

jvdd commented Apr 26, 2023

still 1 job that failed over the nans...

@jonasvdd
Copy link
Member Author

Not consistently, I guess? @jvdd

Comment on lines -81 to 83
gap_mask = x_diff > 4 * med_diff
# After some consideration, we altered this to a 4.1
gap_mask = x_diff > 4.1 * med_diff
if not any(gap_mask):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I arrived at almost the same number when I implemented this..funny how that works

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seems to fail here and there (but not consistently), but already significantly fewer test fails than with 4 🙃

@jonasvdd
Copy link
Member Author

@jvdd, Do I handle here the Interleave gaps issue as well?

@jvdd
Copy link
Member

jvdd commented Apr 27, 2023

@jvdd, Do I handle here the Interleave gaps issue as well?

@jonasvdd sure!

@jonasvdd
Copy link
Member Author

Okay @jvdd, decided to open a seperate PR which will be merged into this one w.r.t. the interleave gaps, see #204

@jvdd jvdd changed the title 🧹 fix typo in docstring + remove LTTB from MinMaxLTTB 🧹 fix typo in docstring + remove LTTB from MinMaxLTTB + remove interleave_gaps Apr 28, 2023
@jonasvdd
Copy link
Member Author

I think this PR can be merged as well @jvdd?

Copy link
Member

@jvdd jvdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Still not entirely sure whether 4.1 is a perfect multiplier for our approximated med_diff.. Nonetheless, this (:cherries: :pick:) value seems to be an improvement over the 4 that was used before 🪄

Let's merge @jonasvdd 🤝

@jvdd jvdd merged commit c37e2d1 into main Apr 30, 2023
@jvdd jvdd deleted the aggregators_polishing branch June 18, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants