-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 fix typo in docstring + remove LTTB from MinMaxLTTB + remove interleave_gaps #201
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #201 +/- ##
==========================================
- Coverage 97.44% 97.11% -0.33%
==========================================
Files 13 13
Lines 979 972 -7
==========================================
- Hits 954 944 -10
- Misses 25 28 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
still 1 job that failed over the nans... |
Not consistently, I guess? @jvdd |
gap_mask = x_diff > 4 * med_diff | ||
# After some consideration, we altered this to a 4.1 | ||
gap_mask = x_diff > 4.1 * med_diff | ||
if not any(gap_mask): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I arrived at almost the same number when I implemented this..funny how that works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still seems to fail here and there (but not consistently), but already significantly fewer test fails than with 4
🙃
@jvdd, Do I handle here the Interleave gaps issue as well? |
Remove interleave gaps
I think this PR can be merged as well @jvdd? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
Still not entirely sure whether 4.1
is a perfect multiplier for our approximated med_diff
.. Nonetheless, this (:cherries: :pick:) value seems to be an improvement over the 4
that was used before 🪄
Let's merge @jonasvdd 🤝
No description provided.