Resample bug, see #137 #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #138 +/- ##
=======================================
Coverage 97.45% 97.45%
=======================================
Files 11 11
Lines 865 865
=======================================
Hits 843 843
Misses 22 22
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jvdd
reviewed
Nov 23, 2022
Comment on lines
402
to
403
| # TODO -> why did we make this assumption | ||
| y_axis = "y" # + xaxis_filter[1:] |
jvdd
reviewed
Nov 23, 2022
| @@ -28,8 +28,9 @@ trace-updater = ">=0.0.8" | |||
| numpy = ">=1.14" | |||
| Flask-Cors = "^3.0.10" | |||
| orjson = "^3.8.0" # Faster json serialization | |||
| Werkzeug = "2.1.2" # Fixating werkzeug version because of: | |||
| # TODO -> check other werkzeug versions: 2.1.2 and 2.1.1 seem to work. | |||
There was a problem hiding this comment.
Should this be included in this PR? For me it's fine to move this to another PR
There was a problem hiding this comment.
I think it can be included!
There was a problem hiding this comment.
Will merge this PR and leave this for what it is
jvdd
approved these changes
Nov 23, 2022
|
Guess the only thing blocking merging this PR is checking other werkzeug versions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #137 137