-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert #554 and require fenicsadapter 2.2.0 to fix subcycling #578
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm testing the changes now. Without subcycling, sold-dealii
and solid-fenics
are in good agreement. When I perform subcycling as described in precice/fenics-adapter#172 I also get the errors we have seen there.
As a solution we have to do the following:
- Release v2.2.0 fenics-adapter#184
- Require
fenicsprecice>=2.2
for this tutorial
I will take care of these steps.
I'm currently performing some tests with the pre-release v2.2.0rc1
and subcycling and the results look good.
@@ -1,4 +1,4 @@ | |||
fenicsprecice~=2.0 | |||
fenicsprecice==2.2.0rc1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fenicsprecice==2.2.0rc1 | |
fenicsprecice~=2.2 |
As soon as precice/fenics-adapter#184 is merged and the new release is available.
This resolves #573 by reverting #554.
For more information, refer to #573.