Revert #554 and require fenicsadapter 2.2.0 to fix subcycling #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I'm testing the changes now. Without subcycling, sold-dealii and solid-fenics are in good agreement. When I perform subcycling as described in precice/fenics-adapter#172 I also get the errors we have seen there.
As a solution we have to do the following:
- Release v2.2.0 fenics-adapter#184
- Require
fenicsprecice>=2.2for this tutorial
I will take care of these steps.
I'm currently performing some tests with the pre-release v2.2.0rc1 and subcycling and the results look good.
| @@ -1,4 +1,4 @@ | |||
| fenicsprecice~=2.0 | |||
| fenicsprecice==2.2.0rc1 | |||
There was a problem hiding this comment.
Suggested change
| fenicsprecice==2.2.0rc1 | |
| fenicsprecice~=2.2 |
As soon as precice/fenics-adapter#184 is merged and the new release is available.
BenjaminRodenberg
changed the title
BenjaminRodenberg
added a commit
to BenjaminRodenberg/tutorials
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #573 by reverting #554.
For more information, refer to #573.