Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally use initial macro data to initialize micro simulations #104

Merged
merged 5 commits into from
May 17, 2024

Conversation

IshaanDesai
Copy link
Member

This PR adds functionality to use initial data written by the macro side for initializing the micro simulations. This is done only when the initialize() function in the micro simulation library requires the macro data as input. The requirements of data are checked rigorously to catch possible mismatches.

@IshaanDesai IshaanDesai self-assigned this May 14, 2024
@IshaanDesai IshaanDesai added the enhancement Enchance existing functionality label May 14, 2024
@IshaanDesai
Copy link
Member Author

Tests for this functionality are purposely not added here, because it was concluded that the embedded initialize() call in the MicroManager class is problematic and needs to be removed. When the call is made explicit, testing will be simplified, and the tests for this functionality will be directly added in the new test framework.

@IshaanDesai IshaanDesai marked this pull request as ready for review May 17, 2024 09:24
Copy link
Collaborator

@mathiskelm mathiskelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@IshaanDesai IshaanDesai merged commit cf87204 into develop May 17, 2024
10 checks passed
@IshaanDesai IshaanDesai deleted the micro-sim-init-data branch May 17, 2024 11:03
@IshaanDesai IshaanDesai mentioned this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enchance existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide functionality to pass a quantities to the micro simulations during initialization
2 participants