Moving the mask computation into initialization #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partitioned heat conduction seems to be working now, at least there are no more errors. However, there's still a lot that's commented out because it hasn't been adapted to dolfinx yet. The latest version of dolfinx is required to run the case!
precice#14) * working on a fix for the partitioned-heat-equation tutorial * working on a fix for the partitioned-heat-equation tutorial * Trying out solutions for L2 error computation from the Discourse * Error computation in working state * Formatting * Calculate relative error instead of absolute error and clean up script * Formatting Co-authored-by: Ishaan Desai <ishaandesai@gmail.com>
Caused failure of partitioned heat equation tutorial
Actually remove problematic line.
…PhilipHildebrand/fenicsx-adapter into merge-partitioned-heat-equation
PhilipHildebrand
added a commit
to PhilipHildebrand/fenicsx-adapter
that referenced
this pull request
Jan 23, 2023
… vector-valued functions (precice#15) * Remove parallelization (see precice#22) * Remove PointSources (see precice#24) * Remove tests and support for vector functions (precice#9) * Remove parallelization (see precice#22) * Update tests. * Remove nearest projection. * Working version with partitioned heat equation. * Update CI * update to doflinx v0.4.1 (should also work with v0.5.2) Co-authored-by: Ishaan Desai <ishaandesai@gmail.com> Co-authored-by: Benjamin Rodenberg <benjamin.rodenberg@in.tum.de> Co-authored-by: Arved Enders-Seidlitz <arved.enders-seidlitz@ikz-berlin.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to move the mask computation into the initialization of the adapter. This also resolves the issue about the dirty fix.