-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to CalculiX 2.19 #78
Conversation
Fixed the crash, I had forgotten a few stars when dealing with some pointers. 🙈 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing to fix first in the Makefile.
Other than that, I tried running:
- perpendicular-flap: runs and results look reasonable.
- heat-exchanger: runs, but OpenFOAM explodes with negative temperatures already at
Time = 5
. Last time I checked, it was running fine (and I am using again preCICE v2.3.0, as released). I will investigate.- Update: Same for CalculiX 2.16.
- Update: Same for CalculiX 2.16 with OpenFOAM v2106 and adapter from master, as well as tutorials from master. I don't know what is going on, but it does not look related to this PR.
Fixed the bad versioning and added a CCX_VERSION variable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! The code now builds correctly and the perpendicular-flap is running. I have not looked at any code changes, as the diff is quite large (as usual).
I know it is a little late, but I did not find anything unusual about the file changes, so also happy its merged :). |
CalculiX 2.18 was released a few months ago, but 2.19 came before we updated the adapter, so I wrote an updated version for it while skipping 2.18.
Methodology
I took the files
nonlingeo.c
,CalculiX
andccx_2.19.c
from CalculiX source code and reproduced changes by comparing 2.16 version of these files and 2.16 version of the adapter. Quite easy since most changes are documented or easy to spot (/* Adapter */
comment or preCICE calls). I checked withdiff
(between CalculiX 2.16 and adapter 2.16) that I didn't forget any part. (By the way, I wish I had found earlier the optiondiff -w
to ignore identation when comparing files!)Then, simply updating the makefile did the trick.
Status
but crashes at "iteration 1 of time window 51 of 50". This doesn't seem to affect the output. Investigation coming, but if you spot it let me know!FIXED, all worksI don't know if there is something else to check (i.e. other tests than "running tutorials"), so let me know if something else is necessary.
Miscellaneous