Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update node-abi so that electron 14+ get correct node-abi #161

Merged
merged 2 commits into from
Nov 12, 2021
Merged

deps: update node-abi so that electron 14+ get correct node-abi #161

merged 2 commits into from
Nov 12, 2021

Conversation

csett86
Copy link
Contributor

@csett86 csett86 commented Nov 7, 2021

electron/node-abi#113 was fixed in 3.3.0
and is affecting electron 14+

With the current node-abi prebuild-install will download ABI 89 for
electron 14 and 15 and then modules will fail to load as electron 14
has ABI 97 and electon 15 has ABI 98 in reality.

electron/node-abi#113 was fixed in 3.3.0
and is affecting electron 14+

With the current node-abi prebuild-install will download ABI 89 for
electron 14 and 15 and then modules will fail to load as electron 14
has ABI 97 and electon 15 has ABI 98 in reality.
@vweevers
Copy link
Member

vweevers commented Nov 7, 2021

We'll need to drop support of Node < 10 because node-abi@3 did so too. I'm okay with that.

@prebuild/builders Thumbs up or down for dropping Node < 10?

@vweevers vweevers added the semver-major Changes that break backward compatibility label Nov 7, 2021
@vweevers
Copy link
Member

vweevers commented Nov 7, 2021

@csett86 Can you please update the following:

"engines": {
"node": ">=6"
}

node: [6, 8, 10, 12, 14, 16]

@piranna
Copy link
Member

piranna commented Nov 7, 2021

@prebuild/builders Thumbs up or down for dropping Node < 10?

I would take the opportunity to also drop Node < 12, since it's not a maintained version anymore. If not, we'll need to update major version again in the future.

@vweevers
Copy link
Member

vweevers commented Nov 7, 2021

If not, we'll need to update major version again in the future.

That will happen in any case. If not for 12 then for 14 or 16. If there's no effort in supporting a version, as is the case with Node.js 12 atm, we can keep it. Doing it now doesn't save time and hurts folks that are behind the Node.js LTS schedule.

node-abi 3.0.0 did so too
@csett86
Copy link
Contributor Author

csett86 commented Nov 7, 2021

@csett86 Can you please update the following:

"engines": {
"node": ">=6"
}

node: [6, 8, 10, 12, 14, 16]

Done

@vweevers
Copy link
Member

7.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-major Changes that break backward compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants