--path option writing to wrong destination

[dunkmann00]

When I tried to set the --path option when installing a prebuild, it would append the path value twice.

For example:
--path path/to/directory/
unpack resolved to .../path/to/directory/path/to/directory/

I think this is because in bin.js a new process is spawned in the path directory when one is present:

prebuild-install/bin.js

Line 20 in cca87fb

if (rc.path) process.chdir(rc.path)

And then in download.js the path is appended onto the current directory, which it shouldn't because we are already in the directory of the path:

prebuild-install/download.js

Line 106 in cca87fb

resolved = path.resolve(opts.path || '.', binaryName)

So I think in dowload we wouldn't want to check for path again, just always use '.'?

This just pertains to relative paths.

[dunkmann00]

It looks like the opts.path option is also used here:

prebuild-install/download.js

Line 97 in cca87fb

var extract = tfs.extract(opts.path, options).on('entry', updateName)

which is what actually controls where the prebuilt binary is saved.

[vweevers]

If we make rc.path an absolute path - i.e. rc.path = path.resolve(rc.path) - then it wouldn't matter that rc.path is reused multiple times. Might be redundant, but we'd avoid having to refactor.