Orbidder fix integration test and small refactoring (#930)

prebid · Sep 25, 2020 · bd456c1 · bd456c1
1 parent 12fece6
commit bd456c1
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/src/main/java/org/prebid/server/bidder/orbidder/OrbidderBidder.java b/src/main/java/org/prebid/server/bidder/orbidder/OrbidderBidder.java
@@ -36,8 +36,6 @@ public class OrbidderBidder implements Bidder<BidRequest> {
             new TypeReference<ExtPrebid<?, ExtImpOrbidder>>() {
             };
 
-    private static final String DEFAULT_BID_CURRENCY = "USD";
-
     private final String endpointUrl;
     private final JacksonMapper mapper;
 
@@ -103,9 +101,11 @@ public Result<List<BidderBid>> makeBids(HttpCall<BidRequest> httpCall, BidReques
         }
 
         final List<BidderBid> bidderBids = bidResponse.getSeatbid().stream()
+                .filter(Objects::nonNull)
                 .map(SeatBid::getBid)
+                .filter(Objects::nonNull)
                 .flatMap(Collection::stream)
-                .map(bid -> BidderBid.of(bid, BidType.banner, DEFAULT_BID_CURRENCY))
+                .map(bid -> BidderBid.of(bid, BidType.banner, bidResponse.getCur()))
                 .collect(Collectors.toList());
         return Result.of(bidderBids, Collections.emptyList());
     }

diff --git a/.../server/bidder/orbidder/OrbidderTest.java → ...r/bidder/orbidder/OrbidderBidderTest.java b/.../server/bidder/orbidder/OrbidderTest.java → ...r/bidder/orbidder/OrbidderBidderTest.java
@@ -28,7 +28,7 @@
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException;
 
-public class OrbidderTest extends VertxTest {
+public class OrbidderBidderTest extends VertxTest {
 
     private static final String ENDPOINT_URL = "https://test.endpoint.com/";
 

diff --git a/...test/resources/org/prebid/server/it/openrtb2/orbidder/test-auction-orbidder-response.json b/...test/resources/org/prebid/server/it/openrtb2/orbidder/test-auction-orbidder-response.json
@@ -34,7 +34,7 @@
             }
           },
           "id": "1",
-          "impid": "imp123",
+          "impid": "impId001",
           "price": 0.01
         }
       ],

diff --git a/src/test/resources/org/prebid/server/it/openrtb2/orbidder/test-cache-orbidder-request.json b/src/test/resources/org/prebid/server/it/openrtb2/orbidder/test-cache-orbidder-request.json
@@ -4,7 +4,7 @@
       "type": "json",
       "value": {
         "id": "1",
-        "impid": "imp123",
+        "impid": "impId001",
         "price": 0.01,
         "adm": "<b>hi</b>",
         "cid": "test_cid",

diff --git a/src/test/resources/org/prebid/server/it/openrtb2/orbidder/test-orbidder-bid-response.json b/src/test/resources/org/prebid/server/it/openrtb2/orbidder/test-orbidder-bid-response.json
@@ -7,7 +7,7 @@
           "adm": "<b>hi</b>",
           "crid": "test_banner_crid",
           "cid": "test_cid",
-          "impid": "imp123",
+          "impid": "impId001",
           "id": "1",
           "price": 0.01,
           "ext": {