Skip to content

Commit

Permalink
Fix method order
Browse files Browse the repository at this point in the history
  • Loading branch information
AntoxaAntoxic committed Jul 11, 2024
1 parent 0d3b85d commit 5a555ad
Showing 1 changed file with 27 additions and 27 deletions.
54 changes: 27 additions & 27 deletions src/main/java/org/prebid/server/bidder/admatic/AdmaticBidder.java
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,18 @@ public Result<List<HttpRequest<BidRequest>>> makeHttpRequests(BidRequest request
return Result.of(requests, errors);
}

private AdmaticImpExt parseImpExt(Imp imp) {
try {
return mapper.mapper().convertValue(imp.getExt(), TYPE_REFERENCE).getBidder();
} catch (IllegalArgumentException e) {
throw new PreBidException(e.getMessage());
}
}

private String resolveEndpoint(AdmaticImpExt impExt) {
return endpointUrl.replace(HOST_MACRO, HttpUtil.encodeUrl(impExt.getHost()));
}

@Override
public Result<List<BidderBid>> makeBids(BidderCall<BidRequest> httpCall, BidRequest bidRequest) {
try {
Expand All @@ -74,23 +86,6 @@ public Result<List<BidderBid>> makeBids(BidderCall<BidRequest> httpCall, BidRequ
}
}

public static BidType getBidType(Bid bid, Map<String, Imp> impIdToImpMap) {
final String impId = bid.getImpid();
return Optional.ofNullable(impIdToImpMap.get(impId))
.map(imp -> {
if (imp.getBanner() != null) {
return BidType.banner;
} else if (imp.getVideo() != null) {
return BidType.video;
} else if (imp.getXNative() != null) {
return BidType.xNative;
}
return null;
})
.orElseThrow(() -> new PreBidException(
"The impression with ID %s is not present into the request".formatted(impId)));
}

private static List<BidderBid> extractBids(BidRequest bidRequest,
BidResponse bidResponse) {

Expand All @@ -110,16 +105,21 @@ private static List<BidderBid> extractBids(BidRequest bidRequest,
.toList();
}

private AdmaticImpExt parseImpExt(Imp imp) {
try {
return mapper.mapper().convertValue(imp.getExt(), TYPE_REFERENCE).getBidder();
} catch (IllegalArgumentException e) {
throw new PreBidException(e.getMessage());
}
}

private String resolveEndpoint(AdmaticImpExt impExt) {
return endpointUrl.replace(HOST_MACRO, HttpUtil.encodeUrl(impExt.getHost()));
private static BidType getBidType(Bid bid, Map<String, Imp> impIdToImpMap) {
final String impId = bid.getImpid();
return Optional.ofNullable(impIdToImpMap.get(impId))
.map(imp -> {
if (imp.getBanner() != null) {
return BidType.banner;
} else if (imp.getVideo() != null) {
return BidType.video;
} else if (imp.getXNative() != null) {
return BidType.xNative;
}
return null;
})
.orElseThrow(() -> new PreBidException(
"The impression with ID %s is not present into the request".formatted(impId)));
}

}

0 comments on commit 5a555ad

Please sign in to comment.