fix: interstitial ad format for full screen ad units #757

prebid · Jun 3, 2024 · e326de5 · e326de5
1 parent 86bb5a6
commit e326de5
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 4 deletions.
diff --git a/PrebidMobile/PrebidMobile-core/src/main/java/org/prebid/mobile/InterstitialAdUnit.java b/PrebidMobile/PrebidMobile-core/src/main/java/org/prebid/mobile/InterstitialAdUnit.java
@@ -47,6 +47,7 @@ public InterstitialAdUnit(@NonNull String configId, int minWidthPerc, int minHei
     public InterstitialAdUnit(@NonNull String configId, EnumSet<AdUnitFormat> adUnitFormats) {
         super(configId, AdFormat.fromSet(adUnitFormats, true));
 
+        configuration.addAdFormat(AdFormat.INTERSTITIAL);
         if (adUnitFormats.contains(AdUnitFormat.VIDEO)) {
             configuration.setAdPosition(AdPosition.FULLSCREEN);
             configuration.setPlacementType(PlacementType.INTERSTITIAL);

diff --git a/PrebidMobile/PrebidMobile-core/src/main/java/org/prebid/mobile/RewardedVideoAdUnit.java b/PrebidMobile/PrebidMobile-core/src/main/java/org/prebid/mobile/RewardedVideoAdUnit.java
@@ -28,6 +28,7 @@ public class RewardedVideoAdUnit extends VideoBaseAdUnit {
 
     public RewardedVideoAdUnit(@NonNull String configId) {
         super(configId, EnumSet.of(AdFormat.VAST));
+        configuration.addAdFormat(AdFormat.INTERSTITIAL);
         configuration.setRewarded(true);
         configuration.setAdPosition(AdPosition.FULLSCREEN);
         configuration.setPlacementType(PlacementType.INTERSTITIAL);

diff --git a/...e/PrebidMobile-core/src/main/java/org/prebid/mobile/api/rendering/InterstitialAdUnit.java b/...e/PrebidMobile-core/src/main/java/org/prebid/mobile/api/rendering/InterstitialAdUnit.java
@@ -26,6 +26,7 @@
 
 import org.prebid.mobile.AdSize;
 import org.prebid.mobile.LogUtil;
+import org.prebid.mobile.api.data.AdFormat;
 import org.prebid.mobile.api.data.AdUnitFormat;
 import org.prebid.mobile.api.exceptions.AdException;
 import org.prebid.mobile.api.rendering.listeners.InterstitialAdUnitListener;
@@ -114,6 +115,7 @@ public InterstitialAdUnit(
         AdUnitConfiguration adUnitConfiguration = new AdUnitConfiguration();
         adUnitConfiguration.setConfigId(configId);
         adUnitConfiguration.setAdUnitFormats(adUnitFormats);
+        adUnitConfiguration.addAdFormat(AdFormat.INTERSTITIAL);
         init(adUnitConfiguration);
     }
 

diff --git a/...obile/PrebidMobile-core/src/main/java/org/prebid/mobile/api/rendering/RewardedAdUnit.java b/...obile/PrebidMobile-core/src/main/java/org/prebid/mobile/api/rendering/RewardedAdUnit.java
@@ -17,7 +17,9 @@
 package org.prebid.mobile.api.rendering;
 
 import android.content.Context;
+
 import androidx.annotation.Nullable;
+
 import org.prebid.mobile.LogUtil;
 import org.prebid.mobile.api.data.AdFormat;
 import org.prebid.mobile.api.exceptions.AdException;
@@ -28,6 +30,8 @@
 import org.prebid.mobile.rendering.bidding.interfaces.StandaloneRewardedVideoEventHandler;
 import org.prebid.mobile.rendering.bidding.listeners.RewardedVideoEventListener;
 
+import java.util.EnumSet;
+
 public class RewardedAdUnit extends BaseInterstitialAdUnit {
 
     private static final String TAG = RewardedAdUnit.class.getSimpleName();
@@ -109,7 +113,7 @@ public RewardedAdUnit(
 
         AdUnitConfiguration adUnitConfiguration = new AdUnitConfiguration();
         adUnitConfiguration.setConfigId(configId);
-        adUnitConfiguration.setAdFormat(AdFormat.VAST);
+        adUnitConfiguration.setAdFormats(EnumSet.of(AdFormat.INTERSTITIAL, AdFormat.VAST));
         adUnitConfiguration.setRewarded(true);
 
         init(adUnitConfiguration);

diff --git a/PrebidMobile/PrebidMobile-core/src/test/java/org/prebid/mobile/AdUnitSuccessorTest.java b/PrebidMobile/PrebidMobile-core/src/test/java/org/prebid/mobile/AdUnitSuccessorTest.java
@@ -157,15 +157,15 @@ public void testVideoInterstitialAdUnitCreation() {
         AdUnitConfiguration configuration = (AdUnitConfiguration) adUnit.getConfiguration();
 
         assertEquals(testConfigId, configuration.getConfigId());
-        assertEquals(EnumSet.of(AdFormat.VAST), configuration.getAdFormats());
+        assertEquals(EnumSet.of(AdFormat.INTERSTITIAL, AdFormat.VAST), configuration.getAdFormats());
     }
 
     @Test
     public void testRewardedVideoAdUnitCreation() {
         RewardedVideoAdUnit adUnit = new RewardedVideoAdUnit(testConfigId);
         AdUnitConfiguration configuration = adUnit.getConfiguration();
         assertEquals(testConfigId, configuration.getConfigId());
-        assertEquals(EnumSet.of(AdFormat.VAST), configuration.getAdFormats());
+        assertEquals(EnumSet.of(AdFormat.INTERSTITIAL, AdFormat.VAST), configuration.getAdFormats());
     }
 
     @Test

diff --git a/...ebidMobile-core/src/test/java/org/prebid/mobile/api/rendering/InterstitialAdUnitTest.java b/...ebidMobile-core/src/test/java/org/prebid/mobile/api/rendering/InterstitialAdUnitTest.java
@@ -139,7 +139,7 @@ public void createInterstitialAdUnitNoEventHandler_InstanceCreatedStandaloneEven
         assertNotNull(interstitialAdUnit);
         assertTrue(eventHandler instanceof StandaloneInterstitialEventHandler);
         assertNotNull(bidLoader);
-        assertEquals(EnumSet.of(AdFormat.VAST), interstitialAdUnit.adUnitConfig.getAdFormats());
+        assertEquals(EnumSet.of(AdFormat.INTERSTITIAL, AdFormat.VAST), interstitialAdUnit.adUnitConfig.getAdFormats());
     }
 
     @Test