feat(unification): remove default auto refresh time #370

prebid · Mar 24, 2022 · 75af686 · 75af686
1 parent a70ff1b
commit 75af686
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 12 deletions.
diff --git a/Example/PrebidInternalTestApp/src/main/java/org/prebid/mobile/renderingtestapp/AdFragment.kt b/Example/PrebidInternalTestApp/src/main/java/org/prebid/mobile/renderingtestapp/AdFragment.kt
@@ -50,7 +50,7 @@ abstract class AdFragment : BaseFragment() {
     protected var adUnitId: String = ""
     protected var width = 0
     protected var height = 0
-    protected var refreshDelay = PrebidMobile.AUTO_REFRESH_DELAY_DEFAULT / 1000
+    protected var refreshDelay = PrebidMobile.AUTO_REFRESH_DELAY_MIN / 1000
 
     private var adView: Any? = null
 

diff --git a/...n/java/org/prebid/mobile/renderingtestapp/plugplay/config/AdConfiguratorDialogFragment.kt b/...n/java/org/prebid/mobile/renderingtestapp/plugplay/config/AdConfiguratorDialogFragment.kt
@@ -98,7 +98,7 @@ class AdConfiguratorDialogFragment : DialogFragment() {
         heightField?.setText(argHeight.toString())
         if (mode == AdConfiguratorMode.BANNER) {
             refreshDelayField = dialogView.findViewById(R.id.etRefreshDelay)
-            refreshDelayField?.setText((PrebidMobile.AUTO_REFRESH_DELAY_DEFAULT / 1000).toString())
+            refreshDelayField?.setText((PrebidMobile.AUTO_REFRESH_DELAY_MIN / 1000).toString())
         }
 
         dialogView.findViewById<Button>(R.id.btnLoad).setOnClickListener {

diff --git a/PrebidMobile/PrebidMobile-core/src/main/java/org/prebid/mobile/PrebidMobile.java b/PrebidMobile/PrebidMobile-core/src/main/java/org/prebid/mobile/PrebidMobile.java
@@ -58,12 +58,6 @@ public class PrebidMobile {
      */
     public static final int AUTO_REFRESH_DELAY_MAX = 120_000;
 
-    /**
-     * Default refresh interval. 0 seconds
-     * Used when the refresh interval is not in the AUTO_REFRESH_DELAY_MIN & AUTO_REFRESH_DELAY_MAX range.
-     */
-    public static final int AUTO_REFRESH_DELAY_DEFAULT = 0;
-
     /**
      * Minimum refresh interval allowed. 30 seconds
      */

diff --git a/...e-core/src/main/java/org/prebid/mobile/rendering/bidding/display/MediationBaseAdUnit.java b/...e-core/src/main/java/org/prebid/mobile/rendering/bidding/display/MediationBaseAdUnit.java
@@ -59,6 +59,7 @@ public void onError(AdException exception) {
     protected MediationBaseAdUnit(Context context, String configId, AdSize adSize, PrebidMediationDelegate mediationDelegate) {
         mContextWeakReference = new WeakReference<>(context);
         mMediationDelegate = mediationDelegate;
+        mAdUnitConfig.setAutoRefreshDelay(PrebidMobile.AUTO_REFRESH_DELAY_MIN / 1000);
         initSdk(context);
         initAdConfig(configId, adSize);
         initBidLoader();

diff --git a/...dMobile-core/src/main/java/org/prebid/mobile/units/configuration/AdUnitConfiguration.java b/...dMobile-core/src/main/java/org/prebid/mobile/units/configuration/AdUnitConfiguration.java
@@ -11,7 +11,6 @@
 
 import java.util.*;
 
-import static org.prebid.mobile.PrebidMobile.AUTO_REFRESH_DELAY_DEFAULT;
 
 public class AdUnitConfiguration {
 
@@ -22,7 +21,7 @@ public class AdUnitConfiguration {
     private boolean isBuiltInVideo = false;
 
     private int videoSkipOffset = SKIP_OFFSET_NOT_ASSIGNED;
-    private int autoRefreshDelayInMillis = AUTO_REFRESH_DELAY_DEFAULT;
+    private int autoRefreshDelayInMillis = 0;
     private final int broadcastId = Utils.generateRandomInt();
     private float videoInitialVolume = ExoPlayerView.DEFAULT_INITIAL_VIDEO_VOLUME;
 

diff --git a/...Mobile-core/src/test/java/org/prebid/mobile/rendering/models/AdUnitConfigurationTest.java b/...Mobile-core/src/test/java/org/prebid/mobile/rendering/models/AdUnitConfigurationTest.java
@@ -18,7 +18,6 @@
 
 import org.junit.Test;
 import org.junit.runner.RunWith;
-import org.prebid.mobile.PrebidMobile;
 import org.prebid.mobile.rendering.errors.AdException;
 import org.prebid.mobile.units.configuration.AdUnitConfiguration;
 import org.robolectric.RobolectricTestRunner;
@@ -39,6 +38,6 @@ public void testAdConfiguration() {
         adConfig = new AdUnitConfiguration();
         assertNotNull(adConfig);
         assertNull(err);
-        assertEquals(PrebidMobile.AUTO_REFRESH_DELAY_DEFAULT, adConfig.getAutoRefreshDelay());
+        assertEquals(0, adConfig.getAutoRefreshDelay());
     }
 }