Fix infinite loop when prerendering json imports #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8320de5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
marvinhagemeister
force-pushed
the
json-loading
branch
from
88cd251 to
8320de5
Compare
|
Size Change: +1.27 kB (0%) Total Size: 694 kB
ℹ️ View Unchanged
|
developit
approved these changes
Mar 28, 2021
Merged
This was referenced Mar 28, 2021
Closed
|
If I am not mistaken, this PR supersedes #458 ? |
danielweck
reviewed
Mar 29, 2021
| const [fetched, setFetched] = useState(null); | ||
|
|
||
| useEffect(() => { | ||
| fetch('./pages/foo.json') |
There was a problem hiding this comment.
Just a thought: this feels like a missed opportunity to demonstrate import jsonUrl from 'url:./foo.json'; + fetch(jsonUrl). Otherwise, to the reader the relative path ./pages/foo.json looks like "magic", in the base context of public/pages/json.js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was a combination of multiple smaller issues:
\0json:twice to paths during resolution\0json:files properly during prod buildsFixes #446, fixes #474 .