Use consistent user plugin order #465
Conversation
🦋 Changeset detectedLatest commit: 0737249 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: -2 B (0%) Total Size: 693 kB
ℹ️ View Unchanged
|
marvinhagemeister
force-pushed
the
consitent-plugin-order
branch
from
5f5d2ec to
0737249
Compare
| @@ -87,14 +87,16 @@ export async function bundleProd({ | |||
| input.push('./' + pathToPosix(relative(root, abs))); | |||
| }); | |||
|
|
|||
| // Plugins are pre-sorted | |||
| const split = plugins.findIndex(p => p.enforce !== 'post'); | |||
There was a problem hiding this comment.
Wait this doesn't make sense. The condition should be inverted
There was a problem hiding this comment.
It's supposed to be !== 'pre' - the index that marks the end of the "pre" items.
There was a problem hiding this comment.
Basically the first index of null/'normal'/'post'.
There was a problem hiding this comment.
Imo normal plugins should be moved to the start too. You'll usually want to intercept stuff before we'd internal plugins. It was one of the key learnings in vite
Regression was introduced with #465 (unreleased)
Regression was introduced with #465 (unreleased)
Regression was introduced with #465 (unreleased)
No description provided.