Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw if the user requests a port and it's already taken #463

Merged
merged 1 commit into from
Mar 27, 2021

Conversation

marvinhagemeister
Copy link
Member

Before this PR we'd silently choose a different port, even if the user explicitely requested one via --port or process.env.PORT

@changeset-bot
Copy link

changeset-bot bot commented Mar 27, 2021

🦋 Changeset detected

Latest commit: 2f36c6f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wmr Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2021

Size Change: +87 B (0%)

Total Size: 692 kB

Filename Size Change
packages/wmr/wmr.cjs 660 kB +87 B (0%)
ℹ️ View Unchanged
Filename Size Change
examples/demo/dist/about/index.html 657 B 0 B
examples/demo/dist/assets/Calendar.********.css 702 B 0 B
examples/demo/dist/assets/style.********.css 386 B 0 B
examples/demo/dist/chunks/class-fields.********.js 201 B 0 B
examples/demo/dist/chunks/compat.********.js 15.3 kB 0 B
examples/demo/dist/chunks/index.********.js 200 B 0 B
examples/demo/dist/chunks/prerender.********.js 2.44 kB 0 B
examples/demo/dist/class-fields/index.html 635 B 0 B
examples/demo/dist/compat/index.html 1.49 kB 0 B
examples/demo/dist/env/index.html 712 B 0 B
examples/demo/dist/error/index.html 646 B 0 B
examples/demo/dist/files/index.html 675 B 0 B
examples/demo/dist/index.********.js 7.19 kB 0 B
examples/demo/dist/index.html 703 B 0 B
examples/demo/dist/lazy-and-late/index.html 658 B 0 B

compressed-size-action

@marvinhagemeister
Copy link
Member Author

Not sure what lighthouse is stumbling upon. Seems unrelated to this PR.

@marvinhagemeister marvinhagemeister merged commit 63fb458 into main Mar 27, 2021
@marvinhagemeister marvinhagemeister deleted the explicit-port branch March 27, 2021 09:53
@github-actions github-actions bot mentioned this pull request Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants