(wmr) - clear module-graph when the update isn't accepted (#430)

* clear module-graph when the update isn't accepted * Update five-carrots-juggle.md
preactjs · Mar 14, 2021 · b225cc2 · b225cc2
1 parent edca6ce
commit b225cc2
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/.changeset/five-carrots-juggle.md b/.changeset/five-carrots-juggle.md
@@ -0,0 +1,5 @@
+---
+'wmr': patch
+---
+
+Fix reload issue, when the bubbling hmr doesn't find a proper boundary it will give the browser a refresh signal (F5) which needs to clear the module-graph as modules could still be marked as stale which wouldn't be needed
diff --git a/packages/wmr/demo/public/index.tsx b/packages/wmr/demo/public/index.tsx
@@ -54,3 +54,4 @@ export async function prerender(data) {
 
 // @ts-ignore
 if (module.hot) module.hot.accept(u => hydrate(<u.module.App />, document.body));
+
diff --git a/packages/wmr/src/wmr-middleware.js b/packages/wmr/src/wmr-middleware.js
@@ -163,11 +163,15 @@ export default function wmrMiddleware({
 			pendingChanges.add('/' + filename);
 		} else if (/\.(mjs|[tj]sx?)$/.test(filename)) {
 			if (!bubbleUpdates(filename)) {
+				moduleGraph.clear();
+				pendingChanges.clear();
 				clearTimeout(timeout);
 				onChange({ reload: true });
 			}
 		} else {
 			WRITE_CACHE.delete(filename);
+			moduleGraph.clear();
+			pendingChanges.clear();
 			clearTimeout(timeout);
 			onChange({ reload: true });
 		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -54,3 +54,4 @@ export async function prerender(data) {

		// @ts-ignore
		if (module.hot) module.hot.accept(u => hydrate(<u.module.App />, document.body));