Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some byte improvements #4321

Merged
merged 7 commits into from
Mar 25, 2024
Merged

Some byte improvements #4321

merged 7 commits into from
Mar 25, 2024

Conversation

JoviDeCroock
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 23, 2024 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -1% - +5% (-0.85ms - +3.62ms)
    preact-local vs preact-main
  • 03_update10th1k_x16: unsure 🔍 -3% - +3% (-1.04ms - +1.07ms)
    preact-local vs preact-main
  • 07_create10k: unsure 🔍 -1% - +0% (-7.97ms - +4.23ms)
    preact-local vs preact-main
  • filter_list: unsure 🔍 -2% - +1% (-0.27ms - +0.20ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -0% - +1% (-0.23ms - +0.70ms)
    preact-local vs preact-main
  • many_updates: unsure 🔍 -5% - +2% (-0.80ms - +0.28ms)
    preact-local vs preact-main
  • text_update: unsure 🔍 -5% - +0% (-0.12ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +2% (-0.04ms - +0.41ms)
    preact-local vs preact-main

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main

Results

02_replace1k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main71.43ms - 74.54ms-unsure 🔍
-5% - +1%
-3.62ms - +0.85ms		unsure 🔍
-3% - +1%
-2.53ms - +0.92ms
preact-local72.76ms - 75.98msunsure 🔍
-1% - +5%
-0.85ms - +3.62ms		-unsure 🔍
-2% - +3%
-1.19ms - +2.35ms
preact-hooks73.05ms - 74.53msunsure 🔍
-1% - +3%
-0.92ms - +2.53ms		unsure 🔍
-3% - +2%
-2.35ms - +1.19ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main3.38ms - 3.38ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms		faster ✔
1% - 1%
0.02ms - 0.02ms
preact-local3.38ms - 3.39msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-faster ✔
0% - 1%
0.02ms - 0.02ms
preact-hooks3.40ms - 3.41msslower ❌
1% - 1%
0.02ms - 0.02ms		slower ❌
0% - 1%
0.02ms - 0.02ms		-

run-warmup-0

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main28.95ms - 30.28ms-unsure 🔍
-2% - +3%
-0.70ms - +0.82ms		unsure 🔍
-3% - +2%
-0.95ms - +0.63ms
preact-local29.19ms - 29.92msunsure 🔍
-3% - +2%
-0.82ms - +0.70ms		-unsure 🔍
-3% - +1%
-0.78ms - +0.34ms
preact-hooks29.35ms - 30.20msunsure 🔍
-2% - +3%
-0.63ms - +0.95ms		unsure 🔍
-1% - +3%
-0.34ms - +0.78ms		-

run-warmup-1

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main37.43ms - 39.07ms-unsure 🔍
-4% - +2%
-1.62ms - +0.63ms		faster ✔
2% - 7%
0.71ms - 2.67ms
preact-local37.97ms - 39.52msunsure 🔍
-2% - +4%
-0.63ms - +1.62ms		-faster ✔
1% - 5%
0.25ms - 2.13ms
preact-hooks39.40ms - 40.48msslower ❌
2% - 7%
0.71ms - 2.67ms		slower ❌
1% - 6%
0.25ms - 2.13ms		-

run-warmup-2

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main25.39ms - 25.68ms-unsure 🔍
-2% - +1%
-0.42ms - +0.17ms		unsure 🔍
-2% - +1%
-0.57ms - +0.18ms
preact-local25.40ms - 25.92msunsure 🔍
-1% - +2%
-0.17ms - +0.42ms		-unsure 🔍
-2% - +1%
-0.50ms - +0.36ms
preact-hooks25.38ms - 26.08msunsure 🔍
-1% - +2%
-0.18ms - +0.57ms		unsure 🔍
-1% - +2%
-0.36ms - +0.50ms		-

run-warmup-3

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main24.28ms - 25.42ms-slower ❌
0% - 6%
0.07ms - 1.50ms		slower ❌
1% - 8%
0.15ms - 1.80ms
preact-local23.64ms - 24.49msfaster ✔
0% - 6%
0.07ms - 1.50ms		-unsure 🔍
-2% - +4%
-0.54ms - +0.92ms
preact-hooks23.28ms - 24.47msfaster ✔
1% - 7%
0.15ms - 1.80ms		unsure 🔍
-4% - +2%
-0.92ms - +0.54ms		-

run-warmup-4

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main24.31ms - 25.72ms-unsure 🔍
-1% - +6%
-0.33ms - +1.38ms		faster ✔
0% - 7%
0.02ms - 1.81ms
preact-local24.01ms - 24.97msunsure 🔍
-5% - +1%
-1.38ms - +0.33ms		-faster ✔
3% - 8%
0.71ms - 2.17ms
preact-hooks25.37ms - 26.48msslower ❌
0% - 7%
0.02ms - 1.81ms		slower ❌
3% - 9%
0.71ms - 2.17ms		-

run-final

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main21.82ms - 22.72ms-unsure 🔍
-3% - +2%
-0.63ms - +0.46ms		faster ✔
2% - 7%
0.50ms - 1.77ms
preact-local22.04ms - 22.67msunsure 🔍
-2% - +3%
-0.46ms - +0.63ms		-faster ✔
2% - 7%
0.50ms - 1.59ms
preact-hooks22.96ms - 23.85msslower ❌
2% - 8%
0.50ms - 1.77ms		slower ❌
2% - 7%
0.50ms - 1.59ms		-
03_update10th1k_x16

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main32.68ms - 34.09ms-unsure 🔍
-3% - +3%
-1.07ms - +1.04ms		unsure 🔍
-1% - +5%
-0.48ms - +1.52ms
preact-local32.61ms - 34.19msunsure 🔍
-3% - +3%
-1.04ms - +1.07ms		-unsure 🔍
-2% - +5%
-0.52ms - +1.60ms
preact-hooks32.16ms - 33.57msunsure 🔍
-5% - +1%
-1.52ms - +0.48ms		unsure 🔍
-5% - +2%
-1.60ms - +0.52ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main3.35ms - 3.36ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms		faster ✔
0% - 1%
0.01ms - 0.02ms
preact-local3.35ms - 3.36msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-faster ✔
0% - 1%
0.01ms - 0.02ms
preact-hooks3.37ms - 3.38msslower ❌
0% - 1%
0.01ms - 0.02ms		slower ❌
0% - 1%
0.01ms - 0.02ms		-
07_create10k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main889.77ms - 899.90ms-unsure 🔍
-0% - +1%
-4.23ms - +7.97ms		unsure 🔍
-1% - +1%
-8.22ms - +4.84ms
preact-local889.56ms - 896.36msunsure 🔍
-1% - +0%
-7.97ms - +4.23ms		-unsure 🔍
-1% - +0%
-8.91ms - +1.79ms
preact-hooks892.39ms - 900.65msunsure 🔍
-1% - +1%
-4.84ms - +8.22ms		unsure 🔍
-0% - +1%
-1.79ms - +8.91ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main26.16ms - 26.16ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-local26.16ms - 26.16msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks26.18ms - 26.18msunsure 🔍
+0% - +0%
+0.02ms - +0.02ms		unsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
filter_list

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main16.49ms - 16.87ms-unsure 🔍
-1% - +2%
-0.20ms - +0.27ms		unsure 🔍
-0% - +2%
-0.06ms - +0.32ms
preact-local16.51ms - 16.78msunsure 🔍
-2% - +1%
-0.27ms - +0.20ms		-unsure 🔍
-0% - +1%
-0.04ms - +0.23ms
preact-hooks16.53ms - 16.57msunsure 🔍
-2% - +0%
-0.32ms - +0.06ms		unsure 🔍
-1% - +0%
-0.23ms - +0.04ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main1.42ms - 1.43ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
2% - 2%
0.02ms - 0.03ms
preact-local1.42ms - 1.43msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
2% - 2%
0.02ms - 0.03ms
preact-hooks1.45ms - 1.45msslower ❌
2% - 2%
0.02ms - 0.03ms		slower ❌
2% - 2%
0.02ms - 0.03ms		-
hydrate1k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main72.33ms - 72.90ms-unsure 🔍
-1% - +0%
-0.70ms - +0.23ms		unsure 🔍
-2% - +0%
-1.41ms - +0.03ms
preact-local72.49ms - 73.22msunsure 🔍
-0% - +1%
-0.23ms - +0.70ms		-unsure 🔍
-2% - +0%
-1.21ms - +0.30ms
preact-hooks72.65ms - 73.97msunsure 🔍
-0% - +2%
-0.03ms - +1.41ms		unsure 🔍
-0% - +2%
-0.30ms - +1.21ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main6.05ms - 6.05ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		unsure 🔍
-0% - -0%
-0.03ms - -0.02ms
preact-local6.05ms - 6.05msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.03ms - -0.02ms
preact-hooks6.07ms - 6.07msunsure 🔍
+0% - +0%
+0.02ms - +0.03ms		unsure 🔍
+0% - +0%
+0.02ms - +0.03ms		-
many_updates

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main16.87ms - 17.69ms-unsure 🔍
-2% - +5%
-0.28ms - +0.80ms		unsure 🔍
-2% - +4%
-0.41ms - +0.70ms
preact-local16.67ms - 17.37msunsure 🔍
-5% - +2%
-0.80ms - +0.28ms		-unsure 🔍
-4% - +2%
-0.63ms - +0.40ms
preact-hooks16.76ms - 17.51msunsure 🔍
-4% - +2%
-0.70ms - +0.41ms		unsure 🔍
-2% - +4%
-0.40ms - +0.63ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main4.52ms - 4.53ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
0% - 1%
0.02ms - 0.02ms
preact-local4.52ms - 4.53msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
0% - 1%
0.02ms - 0.02ms
preact-hooks4.54ms - 4.55msslower ❌
0% - 1%
0.02ms - 0.02ms		slower ❌
0% - 1%
0.02ms - 0.02ms		-
text_update

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main2.49ms - 2.59ms-unsure 🔍
-0% - +5%
-0.00ms - +0.12ms		faster ✔
4% - 9%
0.10ms - 0.24ms
preact-local2.45ms - 2.52msunsure 🔍
-5% - +0%
-0.12ms - +0.00ms		-faster ✔
6% - 10%
0.17ms - 0.29ms
preact-hooks2.67ms - 2.76msslower ❌
4% - 9%
0.10ms - 0.24ms		slower ❌
7% - 12%
0.17ms - 0.29ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main0.80ms - 0.80ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
3% - 4%
0.02ms - 0.03ms
preact-local0.80ms - 0.80msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
2% - 4%
0.02ms - 0.03ms
preact-hooks0.82ms - 0.84msslower ❌
3% - 4%
0.02ms - 0.03ms		slower ❌
2% - 4%
0.02ms - 0.03ms		-
todo

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main26.97ms - 27.19ms-unsure 🔍
-2% - +0%
-0.41ms - +0.04ms		faster ✔
3% - 5%
0.83ms - 1.35ms
preact-local27.06ms - 27.47msunsure 🔍
-0% - +2%
-0.04ms - +0.41ms		-faster ✔
2% - 4%
0.59ms - 1.22ms
preact-hooks27.93ms - 28.40msslower ❌
3% - 5%
0.83ms - 1.35ms		slower ❌
2% - 4%
0.59ms - 1.22ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main0.88ms - 0.88ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
3% - 3%
0.03ms - 0.03ms
preact-local0.88ms - 0.88msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
3% - 3%
0.03ms - 0.03ms
preact-hooks0.91ms - 0.91msslower ❌
3% - 3%
0.03ms - 0.03ms		slower ❌
3% - 3%
0.03ms - 0.03ms		-

tachometer-reporter-action v2 for Benchmarks

JoviDeCroock
JoviDeCroock commented Mar 23, 2024
View reviewed changes
src/diff/props.js Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 23, 2024 •
edited
Loading

Size Change: -25 B (0%)

Total Size: 60.3 kB

Filename Size Change
dist/preact.js 4.55 kB -3 B (0%)
dist/preact.min.js 4.59 kB -4 B (0%)
dist/preact.min.module.js 4.59 kB -4 B (0%)
dist/preact.min.umd.js 4.62 kB -2 B (0%)
dist/preact.module.js 4.57 kB -3 B (0%)
dist/preact.umd.js 4.63 kB -9 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 4.05 kB 0 B
compat/dist/compat.module.js 3.98 kB 0 B
compat/dist/compat.umd.js 4.11 kB 0 B
debug/dist/debug.js 3.52 kB 0 B
debug/dist/debug.module.js 3.52 kB 0 B
debug/dist/debug.umd.js 3.6 kB 0 B
devtools/dist/devtools.js 231 B 0 B
devtools/dist/devtools.module.js 240 B 0 B
devtools/dist/devtools.umd.js 314 B 0 B
hooks/dist/hooks.js 1.55 kB 0 B
hooks/dist/hooks.module.js 1.59 kB 0 B
hooks/dist/hooks.umd.js 1.63 kB 0 B
jsx-runtime/dist/jsxRuntime.js 963 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 938 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 1.04 kB 0 B
test-utils/dist/testUtils.js 453 B 0 B
test-utils/dist/testUtils.module.js 454 B 0 B
test-utils/dist/testUtils.umd.js 536 B 0 B

compressed-size-action

@JoviDeCroock JoviDeCroock changed the title Some performance improvements/byte-saving Some performance improvements Mar 23, 2024
@coveralls
Copy link

coveralls commented Mar 23, 2024 •
edited
Loading

Coverage Status

coverage: 99.601%. remained the same
when pulling 576dbb7 on save-bytes
into 8759dad on main.

@JoviDeCroock JoviDeCroock changed the title Some performance improvements Some byte improvements Mar 23, 2024
@JoviDeCroock JoviDeCroock merged commit d3d57db into main Mar 25, 2024
13 checks passed
@JoviDeCroock JoviDeCroock deleted the save-bytes branch March 25, 2024 06:42
@JoviDeCroock JoviDeCroock mentioned this pull request Apr 9, 2024
Merged
@X-oss-byte X-oss-byte mentioned this pull request May 21, 2024
Open
@q1blue q1blue mentioned this pull request May 24, 2024
Open
@Leeze555 Leeze555 mentioned this pull request May 31, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Jun 5, 2024
Open
@Jircs1 Jircs1 mentioned this pull request Jun 10, 2024
Open
This was referenced Jun 15, 2024
Open
Open
Open
@vAHiD55555 vAHiD55555 mentioned this pull request Jun 20, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Jul 22, 2024
Open
@ZeroXClem ZeroXClem mentioned this pull request Aug 12, 2024
Closed
This was referenced Aug 14, 2024
Open
Open
@ramzimalhas ramzimalhas mentioned this pull request Aug 22, 2024
Open
This was referenced Sep 3, 2024
Open
Open
@ntavassoli-dot ntavassoli-dot mentioned this pull request Sep 13, 2024
Open
This was referenced Sep 13, 2024
Open
Open
@organich organich mentioned this pull request Sep 24, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoviDeCroock @coveralls @marvinhagemeister