Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add reconcile bug test #4287

Merged
merged 14 commits into from
Feb 22, 2024
Merged

chore: add reconcile bug test #4287

merged 14 commits into from
Feb 22, 2024

Conversation

marvinhagemeister
Copy link
Member

@squidfunk ran into this case and I think it might be related to one I'm running into with Fresh. With his reproduction case I was able to narrow it down further to a minimal test case. Haven't had the time to look into this yet.

Copy link

github-actions bot commented Feb 21, 2024

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -3% - +2% (-2.79ms - +1.30ms)
    preact-local vs preact-main
  • 03_update10th1k_x16: unsure 🔍 -4% - +2% (-1.44ms - +0.84ms)
    preact-local vs preact-main
  • 07_create10k: unsure 🔍 -1% - +1% (-8.68ms - +6.38ms)
    preact-local vs preact-main
  • filter_list: unsure 🔍 -0% - +0% (-0.07ms - +0.05ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +1% (-1.10ms - +0.47ms)
    preact-local vs preact-main
  • many_updates: unsure 🔍 -1% - +3% (-0.16ms - +0.47ms)
    preact-local vs preact-main
  • text_update: unsure 🔍 -2% - +5% (-0.05ms - +0.12ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +0% (-0.36ms - +0.10ms)
    preact-local vs preact-main

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main
  • 07_create10k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • text_update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main

Results

02_replace1k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main78.27ms - 81.83ms-unsure 🔍
-2% - +4%
-1.30ms - +2.79ms
unsure 🔍
-0% - +4%
-0.34ms - +3.37ms
preact-local78.31ms - 80.30msunsure 🔍
-3% - +2%
-2.79ms - +1.30ms
-unsure 🔍
-0% - +2%
-0.36ms - +1.89ms
preact-hooks78.01ms - 79.06msunsure 🔍
-4% - +0%
-3.37ms - +0.34ms
unsure 🔍
-2% - +0%
-1.89ms - +0.36ms
-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main3.48ms - 3.48ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
faster ✔
1% - 1%
0.02ms - 0.02ms
preact-local3.48ms - 3.49msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-faster ✔
0% - 1%
0.02ms - 0.02ms
preact-hooks3.50ms - 3.50msslower ❌
1% - 1%
0.02ms - 0.02ms
slower ❌
0% - 1%
0.02ms - 0.02ms
-

run-warmup-0

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main29.74ms - 30.56ms-unsure 🔍
-3% - +1%
-0.87ms - +0.31ms
faster ✔
0% - 4%
0.04ms - 1.25ms
preact-local30.00ms - 30.85msunsure 🔍
-1% - +3%
-0.31ms - +0.87ms
-unsure 🔍
-3% - +1%
-0.98ms - +0.24ms
preact-hooks30.35ms - 31.24msslower ❌
0% - 4%
0.04ms - 1.25ms
unsure 🔍
-1% - +3%
-0.24ms - +0.98ms
-

run-warmup-1

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main39.85ms - 41.33ms-unsure 🔍
-4% - +1%
-1.73ms - +0.36ms
faster ✔
0% - 5%
0.18ms - 2.04ms
preact-local40.54ms - 42.01msunsure 🔍
-1% - +4%
-0.36ms - +1.73ms
-unsure 🔍
-3% - +1%
-1.35ms - +0.49ms
preact-hooks41.14ms - 42.26msslower ❌
0% - 5%
0.18ms - 2.04ms
unsure 🔍
-1% - +3%
-0.49ms - +1.35ms
-

run-warmup-2

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main26.75ms - 27.39ms-unsure 🔍
-1% - +2%
-0.37ms - +0.48ms
unsure 🔍
-1% - +2%
-0.16ms - +0.60ms
preact-local26.74ms - 27.29msunsure 🔍
-2% - +1%
-0.48ms - +0.37ms
-unsure 🔍
-1% - +2%
-0.18ms - +0.51ms
preact-hooks26.64ms - 27.05msunsure 🔍
-2% - +1%
-0.60ms - +0.16ms
unsure 🔍
-2% - +1%
-0.51ms - +0.18ms
-

run-warmup-3

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main25.32ms - 26.66ms-unsure 🔍
-4% - +3%
-0.93ms - +0.90ms
unsure 🔍
-4% - +3%
-0.98ms - +0.82ms
preact-local25.39ms - 26.62msunsure 🔍
-3% - +4%
-0.90ms - +0.93ms
-unsure 🔍
-4% - +3%
-0.93ms - +0.79ms
preact-hooks25.47ms - 26.67msunsure 🔍
-3% - +4%
-0.82ms - +0.98ms
unsure 🔍
-3% - +4%
-0.79ms - +0.93ms
-

run-warmup-4

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main27.22ms - 28.85ms-unsure 🔍
-6% - +2%
-1.79ms - +0.68ms
faster ✔
1% - 8%
0.33ms - 2.33ms
preact-local27.66ms - 29.52msunsure 🔍
-2% - +6%
-0.68ms - +1.79ms
-unsure 🔍
-6% - +1%
-1.87ms - +0.31ms
preact-hooks28.79ms - 29.94msslower ❌
1% - 8%
0.33ms - 2.33ms
unsure 🔍
-1% - +7%
-0.31ms - +1.87ms
-

run-final

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main23.29ms - 24.90ms-unsure 🔍
-2% - +6%
-0.44ms - +1.41ms
unsure 🔍
-3% - +5%
-0.60ms - +1.19ms
preact-local23.14ms - 24.07msunsure 🔍
-6% - +2%
-1.41ms - +0.44ms
-unsure 🔍
-3% - +2%
-0.80ms - +0.43ms
preact-hooks23.39ms - 24.20msunsure 🔍
-5% - +2%
-1.19ms - +0.60ms
unsure 🔍
-2% - +3%
-0.43ms - +0.80ms
-
03_update10th1k_x16

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main33.98ms - 35.59ms-unsure 🔍
-2% - +4%
-0.84ms - +1.44ms
unsure 🔍
-3% - +4%
-0.97ms - +1.45ms
preact-local33.67ms - 35.29msunsure 🔍
-4% - +2%
-1.44ms - +0.84ms
-unsure 🔍
-4% - +3%
-1.27ms - +1.15ms
preact-hooks33.65ms - 35.44msunsure 🔍
-4% - +3%
-1.45ms - +0.97ms
unsure 🔍
-3% - +4%
-1.15ms - +1.27ms
-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main3.45ms - 3.46ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
faster ✔
0% - 1%
0.01ms - 0.02ms
preact-local3.45ms - 3.46msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms
-faster ✔
0% - 1%
0.01ms - 0.02ms
preact-hooks3.47ms - 3.48msslower ❌
0% - 1%
0.01ms - 0.02ms
slower ❌
0% - 1%
0.01ms - 0.02ms
-
07_create10k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main911.98ms - 923.81ms-unsure 🔍
-1% - +1%
-6.38ms - +8.68ms
unsure 🔍
-1% - +1%
-6.13ms - +6.82ms
preact-local912.08ms - 921.41msunsure 🔍
-1% - +1%
-8.68ms - +6.38ms
-unsure 🔍
-1% - +0%
-6.16ms - +4.56ms
preact-hooks914.91ms - 920.19msunsure 🔍
-1% - +1%
-6.82ms - +6.13ms
unsure 🔍
-0% - +1%
-4.56ms - +6.16ms
-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main26.48ms - 26.48ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-local26.48ms - 26.48msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks26.50ms - 26.50msunsure 🔍
+0% - +0%
+0.02ms - +0.02ms
unsure 🔍
+0% - +0%
+0.02ms - +0.02ms
-
filter_list

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main16.59ms - 16.68ms-unsure 🔍
-0% - +0%
-0.05ms - +0.07ms
unsure 🔍
-1% - +0%
-0.20ms - +0.06ms
preact-local16.59ms - 16.66msunsure 🔍
-0% - +0%
-0.07ms - +0.05ms
-unsure 🔍
-1% - +0%
-0.21ms - +0.05ms
preact-hooks16.58ms - 16.83msunsure 🔍
-0% - +1%
-0.06ms - +0.20ms
unsure 🔍
-0% - +1%
-0.05ms - +0.21ms
-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main1.49ms - 1.49ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
faster ✔
2% - 2%
0.02ms - 0.03ms
preact-local1.49ms - 1.49msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-faster ✔
2% - 2%
0.02ms - 0.03ms
preact-hooks1.52ms - 1.52msslower ❌
2% - 2%
0.02ms - 0.03ms
slower ❌
2% - 2%
0.02ms - 0.03ms
-
hydrate1k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main75.27ms - 76.80ms-unsure 🔍
-1% - +1%
-0.47ms - +1.10ms
unsure 🔍
-2% - +1%
-1.86ms - +0.82ms
preact-local75.55ms - 75.89msunsure 🔍
-1% - +1%
-1.10ms - +0.47ms
-unsure 🔍
-3% - +0%
-1.94ms - +0.28ms
preact-hooks75.46ms - 77.65msunsure 🔍
-1% - +2%
-0.82ms - +1.86ms
unsure 🔍
-0% - +3%
-0.28ms - +1.94ms
-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main6.17ms - 6.18ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
faster ✔
0% - 1%
0.02ms - 0.03ms
preact-local6.18ms - 6.18msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-unsure 🔍
-0% - -0%
-0.03ms - -0.02ms
preact-hooks6.20ms - 6.21msslower ❌
0% - 1%
0.02ms - 0.03ms
unsure 🔍
+0% - +0%
+0.02ms - +0.03ms
-
many_updates

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main16.42ms - 16.73ms-unsure 🔍
-3% - +1%
-0.47ms - +0.16ms
unsure 🔍
-2% - +0%
-0.34ms - +0.05ms
preact-local16.46ms - 17.01msunsure 🔍
-1% - +3%
-0.16ms - +0.47ms
-unsure 🔍
-2% - +2%
-0.29ms - +0.31ms
preact-hooks16.60ms - 16.84msunsure 🔍
-0% - +2%
-0.05ms - +0.34ms
unsure 🔍
-2% - +2%
-0.31ms - +0.29ms
-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main4.60ms - 4.60ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
faster ✔
0% - 1%
0.02ms - 0.02ms
preact-local4.60ms - 4.60msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks4.62ms - 4.62msslower ❌
0% - 1%
0.02ms - 0.02ms
unsure 🔍
+0% - +0%
+0.02ms - +0.02ms
-
text_update

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main2.46ms - 2.57ms-unsure 🔍
-5% - +2%
-0.12ms - +0.05ms
faster ✔
8% - 14%
0.22ms - 0.41ms
preact-local2.49ms - 2.61msunsure 🔍
-2% - +5%
-0.05ms - +0.12ms
-faster ✔
7% - 13%
0.18ms - 0.37ms
preact-hooks2.75ms - 2.91msslower ❌
8% - 16%
0.22ms - 0.41ms
slower ❌
7% - 15%
0.18ms - 0.37ms
-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main0.72ms - 0.72ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
faster ✔
3% - 3%
0.02ms - 0.02ms
preact-local0.72ms - 0.72msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-faster ✔
3% - 3%
0.02ms - 0.02ms
preact-hooks0.75ms - 0.75msslower ❌
3% - 3%
0.02ms - 0.02ms
slower ❌
3% - 3%
0.02ms - 0.02ms
-
todo

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main26.80ms - 27.19ms-unsure 🔍
-0% - +1%
-0.10ms - +0.36ms
faster ✔
1% - 3%
0.38ms - 0.86ms
preact-local26.73ms - 26.99msunsure 🔍
-1% - +0%
-0.36ms - +0.10ms
-faster ✔
2% - 3%
0.57ms - 0.95ms
preact-hooks27.47ms - 27.76msslower ❌
1% - 3%
0.38ms - 0.86ms
slower ❌
2% - 4%
0.57ms - 0.95ms
-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main0.95ms - 0.95ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
faster ✔
3% - 3%
0.03ms - 0.03ms
preact-local0.95ms - 0.95msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-faster ✔
3% - 3%
0.03ms - 0.03ms
preact-hooks0.98ms - 0.98msslower ❌
3% - 3%
0.03ms - 0.03ms
slower ❌
3% - 3%
0.03ms - 0.03ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link

github-actions bot commented Feb 21, 2024

Size Change: +42 B (0%)

Total Size: 60.2 kB

Filename Size Change
dist/preact.js 4.56 kB +8 B (0%)
dist/preact.min.js 4.6 kB +6 B (0%)
dist/preact.min.module.js 4.59 kB +7 B (0%)
dist/preact.min.umd.js 4.63 kB +6 B (0%)
dist/preact.module.js 4.58 kB +8 B (0%)
dist/preact.umd.js 4.64 kB +7 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 4 kB 0 B
compat/dist/compat.module.js 3.92 kB 0 B
compat/dist/compat.umd.js 4.06 kB 0 B
debug/dist/debug.js 3.52 kB 0 B
debug/dist/debug.module.js 3.52 kB 0 B
debug/dist/debug.umd.js 3.6 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.module.js 241 B 0 B
devtools/dist/devtools.umd.js 316 B 0 B
hooks/dist/hooks.js 1.55 kB 0 B
hooks/dist/hooks.module.js 1.59 kB 0 B
hooks/dist/hooks.umd.js 1.63 kB 0 B
jsx-runtime/dist/jsxRuntime.js 963 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 938 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 1.04 kB 0 B
test-utils/dist/testUtils.js 453 B 0 B
test-utils/dist/testUtils.module.js 454 B 0 B
test-utils/dist/testUtils.umd.js 536 B 0 B

compressed-size-action

@coveralls
Copy link

coveralls commented Feb 21, 2024

Coverage Status

coverage: 99.472%. remained the same
when pulling 0435d0c on reconcile-test
into 5b6a62e on main.

marvinhagemeister added a commit to marvinhagemeister/fresh that referenced this pull request Feb 22, 2024
marvinhagemeister added a commit to denoland/fresh that referenced this pull request Feb 22, 2024
@JoviDeCroock JoviDeCroock marked this pull request as ready for review February 22, 2024 08:12
@marvinhagemeister marvinhagemeister merged commit ea75640 into main Feb 22, 2024
13 checks passed
@marvinhagemeister marvinhagemeister deleted the reconcile-test branch February 22, 2024 08:14
@squidfunk
Copy link

Thanks for fixing this so quickly! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants