Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure all WAI-ARIA 1.2 roles are supported in our types #4101

Merged
merged 4 commits into from
Aug 16, 2023

Conversation

rschristian
Copy link
Member

@rschristian rschristian commented Aug 16, 2023

Closes #4098

I pulled the list directly from the spec docs the issue opener kindly provided.

Here's a little script one could use in their browser console to pull the whole list as a type def from the spec docs:

const rolesParent = document.querySelector('#index_role');
const roles = rolesParent.querySelectorAll('dt > a > code');
`type AriaRole = ${[...roles].map(role => `'${role.innerText}'`).join(' | ')} | 'none presentation'`;

@coveralls
Copy link

coveralls commented Aug 16, 2023

Coverage Status

coverage: 99.563%. remained the same when pulling 0dd621f on types/wai-aria-1.2 into 7cd4833 on main.

@rschristian rschristian merged commit 21a6f30 into main Aug 16, 2023
1 check passed
@rschristian rschristian deleted the types/wai-aria-1.2 branch August 16, 2023 07:49
@JoviDeCroock JoviDeCroock mentioned this pull request Aug 19, 2023
@JoviDeCroock JoviDeCroock mentioned this pull request Apr 27, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update AriaRole type to WAI-ARIA 1.2
3 participants