New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IE11 attribute test by sorting them #4070

Merged

marvinhagemeister merged 1 commit into main from ie_11_attr_order

Jul 11, 2023

Member

marvinhagemeister commented Jul 11, 2023

Noticed that a test fails in IE11 because the attributes are in a different order. Pre-sorting them before asserting solves that.


          Fix IE11 attribute test by sorting them

98f6c42

marvinhagemeister requested review from developit, andrewiggins and JoviDeCroock

July 11, 2023 08:17

JoviDeCroock approved these changes

View reviewed changes

coveralls commented Jul 11, 2023

coverage: 99.561%. remained the same when pulling 98f6c42 on ie_11_attr_order into eda404d on main.

marvinhagemeister merged commit 544fcad into main

3 checks passed

marvinhagemeister deleted the ie_11_attr_order branch

July 11, 2023 08:19

JoviDeCroock mentioned this pull request

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet