Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for useEffect ordering with useMemo #3360

Merged
merged 2 commits into from
Dec 8, 2021
Merged

Add test for useEffect ordering with useMemo #3360

merged 2 commits into from
Dec 8, 2021

Conversation

andrewiggins
Copy link
Member

Adds a test for #3354

JoviDeCroock
JoviDeCroock approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should resolve the issues

hooks/test/browser/combinations.test.js Outdated Show resolved Hide resolved
hooks/test/browser/combinations.test.js Outdated Show resolved Hide resolved
@andrewiggins @JoviDeCroock
Apply suggestions from code review
0a43672 
Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
@andrewiggins andrewiggins merged commit e92e29f into master Dec 8, 2021
@andrewiggins andrewiggins deleted the use-effect-ordering branch December 8, 2021 00:29
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.627% when pulling 0a43672 on use-effect-ordering into 8ce72fc on master.

@snyk-bot snyk-bot mentioned this pull request Feb 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

@developit developit Awaiting requested review from developit

@marvinhagemeister marvinhagemeister Awaiting requested review from marvinhagemeister

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewiggins @coveralls @JoviDeCroock