Disable benchmarks on CI #2167
Merged
Disable benchmarks on CI #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running benchmarks on the CI assumes that we always test in the same environment. This doesn't seem to be the case as sometimes the tests are passing and sometimes not. This leads me to conclude that we are assigned a random machine/vm with different specs.
marvinhagemeister
requested review from
andrewiggins,
cristianbote and
JoviDeCroock
JoviDeCroock
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running benchmarks on the CI assumes that we always test in the same environment. This doesn't seem to be the case as sometimes the tests are passing and sometimes not. This leads me to conclude that we are assigned a random machine/vm with different specs and workloads.
Fixes build failures in various PRs like #2160 and #2166 .