Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debug warnings when calling setState or forceUpdate on an unmounted component #2037

Merged
merged 4 commits into from
Oct 24, 2019
Merged

Add debug warnings when calling setState or forceUpdate on an unmounted component #2037

merged 4 commits into from
Oct 24, 2019

Conversation

andrewiggins
Copy link
Member

Also add tests verifying these methods don't throw errors when called on unmounted components

Improves coverage by covering some branches that were missing!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 99.77% when pulling 1d799c5 on feat/improve-set-state-warnings into 90e0db0 on master.

cristianbote
cristianbote approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@cristianbote cristianbote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweeet! 🎉 Awesome stuff!

marvinhagemeister
marvinhagemeister approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Just played around with it a bit in the demo app and it works beautifully 🙌♥️

JoviDeCroock
JoviDeCroock approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@andrewiggins andrewiggins merged commit 2837a74 into master Oct 24, 2019
@andrewiggins andrewiggins deleted the feat/improve-set-state-warnings branch October 24, 2019 21:00
@snyk-bot snyk-bot mentioned this pull request Nov 10, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@cristianbote cristianbote cristianbote approved these changes

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrewiggins @coveralls @marvinhagemeister @cristianbote @JoviDeCroock