-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix internal vnode typings #2015
Fix internal vnode typings #2015
Conversation
Re update
- internal VNode type improperly extended preact.VNode
Oh interesting. Does your TS build look at internal.d.ts? |
I guess it must. I changed the typings in my node_modules and it ran through fine. VSCode also showed an error on the VNode line. |
Oh okay, I think I see it now. This fails when using To be clear, my hesitation is that, internally, Regardless, errors in internal types should never impact consumers, so why that's happening at all is concerning... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the report and taking the time to submit a fix! I'll follow up with a PR to run compat TS tests on build so we can catch these before release
I think #1979 causes some regression in the internal VNode typings.
The internal VNode type incorrectly extended preact.VNode.
The issue showed up in my projects webpack build. The below changes fix the issues.