(fix) - avoid stale closurses #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoviDeCroock
requested review from
developit,
andrewiggins,
marvinhagemeister and
cristianbote
marvinhagemeister
approved these changes
Oct 13, 2019
|
@JoviDeCroock is the comment about not being able to reproduce the issue in tests still relevant? |
|
@marvinhagemeister yes it is. I'm probably making a mistake somewhere ^^ |
|
Thank you for working on this! The effort and the tool is much appreciated. |
|
Test case added -- it was a tricky one for sure |
This was referenced Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem here being I can't seem to reproduce this in a test :/
Fixes: #1998
Edit:
Shaves
-9B