Append portal node to container instead of prepend #1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue described in preactjs#1806. Expected test outcomes were generated by taking the test code and running it with React instead of Preact.
JoviDeCroock
reviewed
Oct 3, 2019
| @@ -452,6 +452,6 @@ describe('Portal', () => { | |||
|
|
|||
| toggle(); | |||
There was a problem hiding this comment.
For sanity's sake could you duplicate this test with <Modal open={open}>Hello</Modal> as firstChild, I remember trying to avoid append for some reason if that works out I'll test something myself and else approve the PR
JoviDeCroock
approved these changes
Oct 6, 2019
marvinhagemeister
approved these changes
Oct 8, 2019
cristianbote
pushed a commit
that referenced
this pull request
Oct 8, 2019
* Append portal node to container instead of prepend This fixes the issue described in #1806. Expected test outcomes were generated by taking the test code and running it with React instead of Preact. * Add additional test for portals testing ordering
This was referenced Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue described in #1806. Expected test outcomes were
generated by taking the test code and running it with React instead of
Preact.