(fix) vnode._children should keep their type as array when diffing #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianbote
requested review from
JoviDeCroock,
andrewiggins,
developit and
marvinhagemeister
|
I still need to add a test for this. |
marvinhagemeister
approved these changes
Sep 11, 2019
developit
reviewed
Sep 11, 2019
cristianbote
deleted the
fix/_children-should-keep-their-type-as-array
branch
|
@cristianbote did you manage to find a test case for this?👀 I had in mind that it would be added before merging, but my comment wasn't clear at all |
|
Oh 💩 totally forgot about it! Will add it asap. Thanks for reminding me! 😟 |
This was referenced Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to pave the way for
preact-reduxwith the latest rc, seems that the_childrenis loosing it's array type wheneverreact-reduxis trying to.forceUpdate().This is the relevant error and log https://travis-ci.org/developit/preact-redux/builds/583356189#L390
Adds
+2B