Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more incorrect dom pointers with sCU #1879

Closed
wants to merge 2 commits into from
Closed

Conversation

marvinhagemeister
Copy link
Member

@marvinhagemeister marvinhagemeister commented Aug 18, 2019

We missed a few cases where it would still keep old DOM around. One test is still failing.

Fixes #1864 🤞

@mzealey
Copy link

mzealey commented Aug 18, 2019

The issue I reported at bottom of #1871 still manifests with these changes.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.881% when pulling 30aaa1b on scu-fix-2 into 372c62f on master.

@mzealey
Copy link

mzealey commented Sep 14, 2019

I've found another similar issue with a node (material UI button) suddenly reappearing in -rc2 and -rc3 but it is a bit complex to trigger even within my application. I think there are still some edge cases missing... In this case I have a <div> with some buttons under which are conditionally rendered. Sometimes the non-conditional ones switch to being first and the conditional ones go to the end of the div. And then sometimes they duplicate after this.

@mzealey
Copy link

mzealey commented Sep 28, 2019

@marvinhagemeister was the above issue with the patch addressed prior to closing - i don't see any additional work on this?

@marvinhagemeister
Copy link
Member Author

@mzealey yup, the same fix was included in #1888, which has landed in master already 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[10.0.0-rc1] Really weird issue with react-redux connect()
3 participants