Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test in IE by sorting attributes. #1836

Merged
merged 1 commit into from
Aug 5, 2019
Merged

Fix test in IE by sorting attributes. #1836

merged 1 commit into from
Aug 5, 2019

Conversation

marvinhagemeister
Copy link
Member

@marvinhagemeister marvinhagemeister commented Aug 5, 2019 •
edited
Loading

Will drop the force saucelab flag once I can verify that this is the correct fix - Alright can confirm that fixes one of the failing IE11 tests 🎉

@marvinhagemeister marvinhagemeister marked this pull request as ready for review August 5, 2019 05:25
@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 99.69% when pulling 307f13e on fix_ie_test into 4618891 on master.

cristianbote
cristianbote approved these changes Aug 5, 2019
View reviewed changes
Copy link
Member

@cristianbote cristianbote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 awesome! 😄 Can confirm the fix as well

@cristianbote cristianbote merged commit 4a8e01d into master Aug 5, 2019
@cristianbote cristianbote deleted the fix_ie_test branch August 5, 2019 05:47
@snyk-bot snyk-bot mentioned this pull request Oct 26, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Nov 10, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianbote cristianbote cristianbote approved these changes

@JoviDeCroock JoviDeCroock Awaiting requested review from JoviDeCroock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marvinhagemeister @coveralls @cristianbote