-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preact/compat's SetStateAction is different from React's SetStateAction #4285
Comments
Can you clarify what the actual problem is? A type being different shouldn't be an issue on its own. |
The type checking throws an error when it shouldn't because the transpiled code works fine. |
But can you give an actual example of this? That's what I'm asking for. There's many ways in which your code could work just fine while not adhering to correct types. |
Example: React: https://codesandbox.io/p/devbox/condescending-wilbur-9gf73z |
* chore: install * refactor: replace library * feat: filter indexer data * refactor: use mock data * feat: updated abi files * fix: contract execution * refactor: transaction helpers * feat: updated erc20 contract abi * fix: lint issue * feat: show validation errors * test: fix * refactor: removed logs * refactor: folders * feat: updated message call * feat: added dev tools * Change PriceOracle metadata * refactor: disable react query storage * fix: swap response * fix: contract failure * Massive update and overhaul for Nabla UI * Some smaller fixes * Use higher contract resource limits * Allow tolerance for estimated gas limits * Funny commit * Temporary commit * Add NumberInput hack * Reoarganize Nabla code * Restructure options of contract hooks * Use new contracts metadata * Fix Swap interface * Fix formatting errors * Remove console.logs * Fix maximum amount on swap pool deposit * Fix maximum amount on backstop pool deposit * Fix maximum amount on backstop pool withdrawal * Fix maxmium amount on swap pool withdrawal and redeem * Remove unused import * Correct types for fix preactjs/preact#4285 * Make balance handling more precise and strict * Create AmountSelector component * Massively update amount and big number logic * Implement Backstop Pool Redeem * Fix code for backstop withdrawals * Fix swaps * Git ignore vite timestamp files * Remove unnecessary code and resolve TODOs * Remove console.log statements * Add debug output to execute message calls * Upgrade api-solang version * Implement PR comments * Improve error messages * Remove dev page * Fix backstop pool withdrawal button enabled error * Use token icons * Rename Nabla to Forex AMM --------- Co-authored-by: Marcel Ebert <mail@marcel-ebert.de> Co-authored-by: Torsten Stüber <15174476+TorstenStueber@users.noreply.github.com>
Describe the bug
preact/compat's SetStateAction is different from React's SetStateAction
Expected behavior
It should be the same, unless the internal mechanics are different (unlikely because the transpiled JS works fine).
The text was updated successfully, but these errors were encountered: