Skip to content

Commit

Permalink
optimize by not accessing the dom
Browse files Browse the repository at this point in the history
  • Loading branch information
JoviDeCroock committed Jun 25, 2024
1 parent e69f7e4 commit bd29648
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions src/diff/children.js
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,12 @@ export function diffChildren(
childVNode._flags & INSERT_VNODE ||
oldVNode._children === childVNode._children
) {
// @ts-expect-error olDom should be present on a DOM node
if (oldDom && oldDom.nodeType === 1 && !parentDom.contains(oldDom)) {
if (
oldDom &&
typeof childVNode.type == 'string' &&
// @ts-expect-error olDom should be present on a DOM node
!parentDom.contains(oldDom)
) {
oldDom = getDomSibling(oldVNode);
}
oldDom = insert(childVNode, oldDom, parentDom);
Expand Down

0 comments on commit bd29648

Please sign in to comment.