Add TypeScript support for Container.contains (#4471)

* Adding contains method * Fix for typescript issue * Update preact.tsx * Update preact.tsx
preactjs · Aug 6, 2024 · 91679e5 · 91679e5
1 parent ab743a9
commit 91679e5
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 1 deletion.
diff --git a/src/diff/children.js b/src/diff/children.js
@@ -373,7 +373,6 @@ function insert(parentVNode, oldDom, parentDom) {
 		if (
 			oldDom &&
 			parentVNode.type &&
-			// @ts-expect-error olDom should be present on a DOM node
 			!parentDom.contains(oldDom)
 		) {
 			oldDom = getDomSibling(parentVNode);

diff --git a/src/index.d.ts b/src/index.d.ts
@@ -293,6 +293,7 @@ interface ContainerNode {
 	readonly firstChild: ContainerNode | null;
 	readonly childNodes: ArrayLike<ContainerNode>;
 
+	contains(other: ContainerNode | null): boolean;
 	insertBefore(node: ContainerNode, child: ContainerNode | null): ContainerNode;
 	appendChild(node: ContainerNode): ContainerNode;
 	removeChild(child: ContainerNode): ContainerNode;

diff --git a/test/ts/preact.tsx b/test/ts/preact.tsx
@@ -97,6 +97,7 @@ function createRootFragment(parent: Element, replaceNode: Element | Element[]) {
 		parentNode: parent,
 		firstChild: replaceNodes[0],
 		childNodes: replaceNodes,
+		contains: (c: Node) => parent.contains(c),
 		insertBefore: insert,
 		appendChild: (c: Node) => insert(c, null),
 		removeChild: function (c: Node) {