feat: Preload routes and repl #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschristian
force-pushed
the
refactor/preload-routes-and-repl
branch
from
6e65b25 to
9378c1d
Compare
rschristian
commented
Jan 7, 2025
| @@ -470,7 +470,6 @@ | |||
| height: 56px; | |||
| min-width: 80px; | |||
| overflow: visible; | |||
| background: var(--color-brand); | |||
There was a problem hiding this comment.
Sorry, drive-by fix: the height of the search bar is ever so slightly larger than the other header items, and, on mobile, it overlaps (and I mean by 1-2px) into the Ukraine banner above it. We don't need a background here though, it's already sitting on a brand-colored header, so removing this fixes that.
JoviDeCroock
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the recent addition of the
.preload()method frompreact-iso@2.8.0, this PR preloads our few split chunks on mouse over and also preloads the REPL Code Editor & Runner chunks. Depending on how quick you are at clicking, can be a pretty considerable speed up.Also refactors
use-resource&use-contenta bit, adding a newuse-replas well. Should be a bit easier to follow now.