Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add instructions for react-dom subpath types #1122

Merged
merged 2 commits into from
Apr 19, 2024
Merged

docs: Add instructions for react-dom subpath types #1122

merged 2 commits into from
Apr 19, 2024

Conversation

rschristian
Copy link
Member

Closes preactjs/preact#3845

Allows users to write the following without type errors:

import ReactDOM from 'react-dom/client'

// or

import { createRoot } from 'react-dom/client'

@JoviDeCroock JoviDeCroock merged commit 197ec84 into master Apr 19, 2024
5 checks passed
@JoviDeCroock JoviDeCroock deleted the fix/react-dom-subtypes-docs branch April 19, 2024 05:22
@bluetech bluetech mentioned this pull request Apr 22, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing types for react-dom/client package in compat
2 participants
@rschristian @JoviDeCroock