Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow any stringified value in class + className #391

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

marvinhagemeister
Copy link
Member

Seems fine to merge, but then again this seems cursed and I'm worried that this list will get longer. For now it seems fine though.

Fixes #390

Copy link

changeset-bot bot commented Aug 28, 2024

🦋 Changeset detected

Latest commit: d80e4dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
preact-render-to-string Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to "cursed, but not an immediate problem"

@marvinhagemeister marvinhagemeister merged commit 6a60e81 into main Aug 29, 2024
1 check passed
@marvinhagemeister marvinhagemeister deleted the cursed-class-name branch August 29, 2024 07:53
@github-actions github-actions bot mentioned this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

className is not correctly coerced to strings for Function proxies
3 participants