fix: wrong spellcheck attribute value #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4621fa3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
approved these changes
Aug 15, 2024
rschristian
approved these changes
Aug 15, 2024
| @@ -635,6 +635,9 @@ function _renderToString( | |||
| } | |||
| } else if (HTML_LOWER_CASE.test(name)) { | |||
| name = name.toLowerCase(); | |||
| if (name === 'spellcheck') { | |||
There was a problem hiding this comment.
Not that it needs to be done here, but I think there's at least a handful of attrs/props that could need (depending on use circumstances) to be preserved as falsey.
Might be something we need to add another regex constant for in the future.
There was a problem hiding this comment.
Yeah, good point. Let's keep out an eye for that.
Merged
This was referenced Sep 14, 2024
<textarea spellCheck={false} /> omits spellcheck attr (should be string "false")
denoland/fresh#2649
Open
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #387