Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve diff table #28

Merged
merged 2 commits into from
Jun 29, 2020
Merged

Improve diff table #28

merged 2 commits into from
Jun 29, 2020

Conversation

fisker
Copy link
Contributor

@fisker fisker commented Jun 19, 2020 •
edited
Loading

Don't show empty icon column.

In order to filter these columns out, I also refactor how the table renders.

Before

Filename Size Change
`one.js` 5 kB +2.5 kB (50%) 🆘
`two.js` -5 kB -2.5 kB (50%) 🆘
`four.js` 4.5 kB +9 B (0%)
ℹ️ View Unchanged
Filename Size Change
`three.js` 300 B 0 B

After

Filename Size Change
`one.js` 5 kB +2.5 kB (50%) 🆘
`two.js` -5 kB -2.5 kB (50%) 🆘
`four.js` 4.5 kB +9 B (0%)
ℹ️ View Unchanged
Filename Size Change
`three.js` 300 B 0 B

developit
developit approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@developit developit merged commit 7d0a588 into preactjs:master Jun 29, 2020
@fisker fisker deleted the table-improve branch June 30, 2020 01:15
@fisker
Copy link
Contributor Author

fisker commented Aug 11, 2020

@developit It has been a long time since this PR merged, can you make a release? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developit developit developit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fisker @developit