Add utility tests and minimumChangeThreshold option #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developit
approved these changes
Jun 13, 2020
|
Released as v2 (v2.0.1). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Jest tests for the utility functions that don't communicate with GitHub. These functions were moved to their own module,
utils.js.I've also added a new configuration option
minimum-change-threshold. Any files that have a delta beneath this value will be considered unchanged. The original default of 1 byte has been retained.This doesn't make any modifications to the comment logic. I figure we can hash that out in a separate PR.
If desired, I can also add a workflow to run the tests on pull requests. Just let me know if you'd like that!