-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow skipping install. #83
Comments
This feature would also help when npm deps require |
Or when #85 & #88 add customization to the installation, but it may be better to pull this step out (do the one thing well principle)? 🤔 name: Compressed Size
on: [pull_request]
jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- run: npm ci
- uses: preactjs/compressed-size-action@v2 lots of variations, e.g.: - run: npm ci --include=dev
# or
- run: npm ci --ignore-scripts
# or, for those in a tight spot
- run: npm ci --force
# or combinations thereof This would also remove the need of supporting various package managers, though that support has already been added for the most used 😅. |
* feat: add autorotate * ci: run pipeline on pull requests and move compressed size job to main ci workflow * chore: add funding * ci: use node 20 * build(deps): upgrade everything 🙏 * build: use latest node in nvm config * build(deps): replace pretty-quick with lint-staged * test: update tests to use consistent port number and ignore unused a11y rules * chore: reaplce `pnpx` with `pnpm` in pre-commit hook * ci: remove install steps from test, it's handled in bootstrap * style: prettier stop changing things pls * test: use custom runtime * ci: yeet compressed action script until pnpm/pnpm#6424 or preactjs/compressed-size-action#83 is resolved * chore: update readme badges * feat: update hook to ignore events and rename props * build: update playwright bootstrap script --------- Co-authored-by: nerdyman <averynerdyman@gmail.com> Co-authored-by: Ricky <nerdyman@users.noreply.github.com>
#85 probably addresses this reasonably, feel free to comment if there's something better we could land though |
Using zero-install PnP with yarn doesn't play well when intalling using
--frozen-lockfile
.Allow opting out of installing all together.
Don't mind doing the PR if it's ok.
The text was updated successfully, but these errors were encountered: