Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub actions example #432

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

atugushev
Copy link
Contributor

@atugushev atugushev commented Dec 1, 2020

https://pre-commit.com/#github-actions-example

Use set-output instead of set-env, since it is removed from GHA.

Addresses jazzband/pip-tools#1012 (comment)

@@ -1728,12 +1728,13 @@ like [azure pipelines](#azure-pipelines-example), github actions also uses
immutable caches:

```yaml
- name: set PY
run: echo "::set-env name=PY::$(python -VV | sha256sum | cut -d' ' -f1)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a less intrusive change is >> $GITHUB_ENV

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, updated in a25c534

Use set-output instead of set-env, since it is removed from GHA.
@atugushev atugushev force-pushed the fix-gha-pre-commit-cache branch from 8d30e9e to a25c534 Compare December 1, 2020 16:43
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit 4003b37 into pre-commit:master Dec 2, 2020
@atugushev atugushev deleted the fix-gha-pre-commit-cache branch December 2, 2020 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants