Detect ScalaFmt config as a scala file #436
Conversation
identify/extensions.py
Outdated
| @@ -31,7 +31,7 @@ | |||
| 'cmake': {'text', 'cmake'}, | |||
| 'cnf': {'text'}, | |||
| 'coffee': {'text', 'coffee'}, | |||
| 'conf': {'text'}, | |||
| 'conf': {'text', 'ini'}, | |||
There was a problem hiding this comment.
this is a breaking change and not generally correct since we can't guarantee the structure of a genetic extension like "conf"
|
When would a .conf file ever be anything other than a configuration file?
…On Thu, 7 Dec 2023 at 18:17, Anthony Sottile ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In identify/extensions.py
<#436 (comment)>:
> @@ -31,7 +31,7 @@
'cmake': {'text', 'cmake'},
'cnf': {'text'},
'coffee': {'text', 'coffee'},
- 'conf': {'text'},
+ 'conf': {'text', 'ini'},
this is a breaking change and not generally correct since we can't
guarantee the structure of a genetic extension like "conf"
—
Reply to this email directly, view it on GitHub
<#436 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABIQ5QOAEFQWJZ2R7DHJ3TYIIB5LAVCNFSM6AAAAABALM7BY6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONZQG44TAMRWGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I think you're confused -- you've set |
…e config file and get latest
no need to be patronising! reverted the change, but I think a config file type would be a useful concept, then ini would be a type of config and it would be clearer |
Add ScalaFmt config so that pre-commit hooks will check changes to the config file and get latest
Currently when I run precommit on a scala repository using a hook that has:
types: [scala]set in .pre-commit-hooks.yaml and I have local edits to my .scalafmt.conf file, precommit doesn't run the hook script as it doesn't find any scala files that have changed.
Identifying .scalafmt.conf as a scala file will fix this