Check if image responds to :read #1066
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@duhast I know it's been a very long time, but do you still have interest in this PR? If so, any chance you can rebase and add a spec for the "alternate" file implementation case? |
|
Oh yeah, it's been a long time 😄 I have this patch working in production for couple years already, however I don't think I'll have time to work on the spec for PR in near future. |
|
@duhast Ok, thanks. I'd like to see this merged, and a spec would help get it there. If you have any suggestions for how to build a spec, they'd be appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This update allows to source image from "alternate" file implementations like
CarrierWave::Storage::Fog::FileandCarrierWave::SanitizedFile.Very convenient when you're working with images stored remotely.